From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Aring <alex.aring@gmail.com>
Cc: Grigory Milev <g.milev@sam-solutions.com>,
barebox@lists.infradead.org,
Dmitry Lavnikevich <d.lavnikevich@sam-solutions.com>
Subject: Re: [PATCH 1/5] mtd: Update internal API to support 64-bit device size
Date: Wed, 12 Mar 2014 21:53:13 +0100 [thread overview]
Message-ID: <20140312205313.GO17250@pengutronix.de> (raw)
In-Reply-To: <20140312205144.GA8051@x61s.Speedport_W_921V_1_24_000>
On Wed, Mar 12, 2014 at 09:51:46PM +0100, Alexander Aring wrote:
> Hi Sascha,
>
> On Wed, Mar 12, 2014 at 09:28:48PM +0100, Sascha Hauer wrote:
> > On Mon, Mar 10, 2014 at 02:39:49PM +0300, Dmitry Lavnikevich wrote:
> > > MTD internal API presently uses 32-bit values to represent device
> > > size. This patch updates them to 64-bits but leaves the external API
> > > unchanged.
> > >
> > > In general, changing from 32-bit to 64-bit values cause little
> > > or no changes to the majority of the code with the following
> > > exceptions:
> > > - printk message formats;
> > > - division and modulus of 64-bit values (mtd_div_by_wb,
> > > mtd_div_by_eb may be used in some of such cases).
> > >
> > > Was tested on phyFLEX i.MX6.
> > >
> >
> > changed master_offset to 64bit aswell and applied this series.
> >
> ok, cool!
>
> But.. damn it there is still a ugly comment in lib/libmtd.c:
>
> "NOTE: No support for 64 bit sizes yet!"
Maybe this should be removed by somebody who has tested this code with
devices > 4GB. I don't have the hardware for this.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-03-12 20:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 11:39 Dmitry Lavnikevich
2014-03-10 11:39 ` [PATCH 2/5] mtd: Support for 4GB partitions Dmitry Lavnikevich
2014-03-10 11:39 ` [PATCH 3/5] ubi: Fix for creating ubi volumes with 64bit size Dmitry Lavnikevich
2014-03-10 11:39 ` [PATCH 4/5] nand: mxs: Check for up to 4 NAND chips Dmitry Lavnikevich
2014-03-10 11:39 ` [PATCH 5/5] nand: mxs: Fix for calculating ecc strength on some types of NAND flash Dmitry Lavnikevich
2014-03-12 20:28 ` [PATCH 1/5] mtd: Update internal API to support 64-bit device size Sascha Hauer
2014-03-12 20:51 ` Alexander Aring
2014-03-12 20:53 ` Sascha Hauer [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-03-07 11:14 Dmitry Lavnikevich
2014-03-10 7:20 ` Sascha Hauer
2014-03-10 8:02 ` Alexander Aring
2014-03-11 5:29 ` Sascha Hauer
2014-03-11 7:50 ` Alexander Aring
2014-03-12 20:28 ` Sascha Hauer
2014-03-10 11:37 ` Dmitry Lavnikevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140312205313.GO17250@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=alex.aring@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=d.lavnikevich@sam-solutions.com \
--cc=g.milev@sam-solutions.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox