mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/8] clocksource: add dummy software-only clocksource
Date: Thu, 13 Mar 2014 07:35:25 +0100	[thread overview]
Message-ID: <20140313063525.GP17250@pengutronix.de> (raw)
In-Reply-To: <20140313090928.5da682507706b31ca2e38b54@gmail.com>

On Thu, Mar 13, 2014 at 09:09:28AM +0400, Antony Pavlov wrote:
> On Wed, 12 Mar 2014 21:50:41 +0100
> Sascha Hauer <s.hauer@pengutronix.de> wrote:
> 
> > On Tue, Mar 11, 2014 at 01:34:34AM +0400, Antony Pavlov wrote:
> > > This driver is very handy for initial barebox porting.
> > > It was used for running barebox on DiGiC2-based camera
> > > and initial porting barebox to Loongson-1 and ar9331.
> > > 
> > > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > > Reported-by: Alexander Aring <alex.aring@gmail.com>
> > > Reported-by: Alexander Shiyan <shc_work@mail.ru>
> > > ---
> > >  drivers/clocksource/Kconfig  |  9 +++++++
> > >  drivers/clocksource/Makefile |  1 +
> > >  drivers/clocksource/dummy.c  | 56 ++++++++++++++++++++++++++++++++++++++++++++
> > >  3 files changed, 66 insertions(+)
> > > 
> > > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> > > index 4ef25ec..f9e00ff 100644
> > > --- a/drivers/clocksource/Kconfig
> > > +++ b/drivers/clocksource/Kconfig
> > > @@ -14,6 +14,15 @@ config CLOCKSOURCE_CLPS711X
> > >  	bool
> > >  	depends on ARCH_CLPS711X
> > >  
> > > +config CLOCKSOURCE_DUMMY
> > > +	bool "Enable dummy software-only clocksource"
> > > +	default n
> > 
> > You can drop the default n, no is the default already. Could you add
> > some help text mentioning that this clocksource is for early bringup
> > only and doesn't provide correct timing?
> 
> Ok, I'll write a help text.
> 
> Yesterday I got working davinci hardware clocksource :)
> So I have no dependency on dummy clocksource for Davinci. 
> 
> What is about the rest of davinci patches?

The rest looks fine, although I would prefer of cause if you used
devicetree for probing devices.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2014-03-13  6:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-10 21:34 [PATCH 0/8] ARM: initial support for TI DaVinci SoCs and virt2real board Antony Pavlov
2014-03-10 21:34 ` [PATCH 1/8] clocksource: add dummy software-only clocksource Antony Pavlov
2014-03-12 20:50   ` Sascha Hauer
2014-03-13  5:09     ` Antony Pavlov
2014-03-13  6:35       ` Sascha Hauer [this message]
2014-03-10 21:34 ` [PATCH 2/8] import _AC and UL macros from linux kernel Antony Pavlov
2014-03-10 21:34 ` [PATCH 3/8] ARM: initial support for TI DaVinci SoCs Antony Pavlov
2014-03-10 21:34 ` [PATCH 4/8] ARM: davinci: add DEBUG_LL support Antony Pavlov
2014-03-10 21:34 ` [PATCH 5/8] ARM: davinci: add documentation Antony Pavlov
2014-03-10 21:34 ` [PATCH 6/8] ARM: davinci: add virt2real board support Antony Pavlov
2014-03-10 21:34 ` [PATCH 7/8] ARM: virt2real: add documentation Antony Pavlov
2014-03-10 21:34 ` [PATCH 8/8] ARM: davinci: add virt2real_defconfig Antony Pavlov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140313063525.GP17250@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox