mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [SPAM] [PATCH] splash: Print error message when no renderer is found
Date: Mon, 17 Mar 2014 08:21:32 +0100	[thread overview]
Message-ID: <20140317072132.GI17250@pengutronix.de> (raw)
In-Reply-To: <20140314171116.GE6478@ns203013.ovh.net>

On Fri, Mar 14, 2014 at 06:11:16PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 11:11 Fri 14 Mar     , Sascha Hauer wrote:
> > the splash command silently fails when no renderer is found for
> > an image type. Print an error message in this case.
> > 
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> >  lib/gui/image_renderer.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/lib/gui/image_renderer.c b/lib/gui/image_renderer.c
> > index 78e5777..9c92983 100644
> > --- a/lib/gui/image_renderer.c
> > +++ b/lib/gui/image_renderer.c
> > @@ -23,6 +23,8 @@ static struct image_renderer *get_renderer(void* buf, size_t bufsize)
> >  			return ir;
> >  	}
> >  
> > +	printf("No renderer found for filetype %s\n", file_type_to_string(type));
> 
> 	eprintf?

ok

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2014-03-17  7:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-14 10:11 Sascha Hauer
2014-03-14 17:11 ` [SPAM] " Jean-Christophe PLAGNIOL-VILLARD
2014-03-17  7:21   ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140317072132.GI17250@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox