From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 4/7] serial: ns16550: add compatible entry for "ingenic, jz4740-uart"
Date: Mon, 24 Mar 2014 07:45:31 +0100 [thread overview]
Message-ID: <20140324064531.GJ17250@pengutronix.de> (raw)
In-Reply-To: <1395487797-16599-5-git-send-email-antonynpavlov@gmail.com>
On Sat, Mar 22, 2014 at 03:29:54PM +0400, Antony Pavlov wrote:
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
> drivers/serial/serial_ns16550.c | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/drivers/serial/serial_ns16550.c b/drivers/serial/serial_ns16550.c
> index aa0992f..7130871 100644
> --- a/drivers/serial/serial_ns16550.c
> +++ b/drivers/serial/serial_ns16550.c
> @@ -257,6 +257,30 @@ static __maybe_unused struct ns16550_drvdata omap_drvdata = {
> .linux_console_name = "ttyO",
> };
>
> +#define JZ_UART_SHIFT 2
> +
> +static void jz_serial_reg_write(unsigned int val, unsigned long base,
> + unsigned char reg_offset)
> +{
> + switch (reg_offset) {
> + case (fcr << JZ_UART_SHIFT):
> + val |= 0x10; /* Enable uart module */
> + break;
You could also do this by overwriting .init_port.
> + case (ier << JZ_UART_SHIFT):
> + val |= (val & 0x4) << 2;
What does this bit do?
Putting driver logic into the register writes is not good. Where this
leads to can be seen in drivers/mmc/host/sdhci-esdhc-imx.c in the
kernel. Could we make fcrval overwritable in drvdata? Or just special
case the fcr register access in ns16550_setbaudrate?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-03-24 6:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-22 11:29 [PATCH 0/7] MIPS: improve Ingenic JZ4755 device tree support Antony Pavlov
2014-03-22 11:29 ` [PATCH 1/7] MIPS: mach-xburst: fix DEBUG_LL=n build error Antony Pavlov
2014-03-22 11:29 ` [PATCH 2/7] MIPS: dts: rzx50: move jz4755 description to the separate file Antony Pavlov
2014-03-22 11:29 ` [PATCH 3/7] serial: ns16550: make it possible to get reg_write() from devtype Antony Pavlov
2014-03-22 11:29 ` [PATCH 4/7] serial: ns16550: add compatible entry for "ingenic, jz4740-uart" Antony Pavlov
2014-03-24 6:45 ` Sascha Hauer [this message]
2014-03-24 20:23 ` Antony Pavlov
2014-03-22 11:29 ` [PATCH 5/7] MIPS: rzx50: drop console initialization in board code Antony Pavlov
2014-03-22 11:29 ` [PATCH 6/7] MIPS: mach-xburst: drop serial.c Antony Pavlov
2014-03-22 11:29 ` [PATCH 7/7] MIPS: boards: rename rzx50 -> ritmix-rzx50 Antony Pavlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140324064531.GJ17250@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox