From: Antony Pavlov <antonynpavlov@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2 0/8] MIPS: improve Ingenic JZ4755 device tree support
Date: Tue, 25 Mar 2014 13:40:40 +0400 [thread overview]
Message-ID: <20140325134040.c957f0ef648db46f734bfaf4@gmail.com> (raw)
In-Reply-To: <1395692034-5821-1-git-send-email-antonynpavlov@gmail.com>
On Tue, 25 Mar 2014 00:13:46 +0400
Antony Pavlov <antonynpavlov@gmail.com> wrote:
Sascha!
Please ignore this series!
There is a error in
[PATCH v2 4/8] serial: ns16550: make FCR setup value part of struct ns16550_priv
This code does not check 'plat' value before checking plat->flags!
+ if (plat->flags & NS16650_FLAG_DISABLE_FIFO)
+ priv->fcrval = FCRVAL & ~FCR_FIFO_EN;
+ else
+ priv->fcrval = FCRVAL;
+
> This patcheseries moves Ingenic JZ4755 UART initialization
> into device tree and makes JZ4755 device tree organization
> more clear.
>
> This patchseries is a part of work on Ingenic chips support
> and prepares MIPS board support switch to device tree.
> Next patchseries will add device tree Ingenic gpio, clk
> and pinctls support.
>
> Changes since v1:
> * use "make FCR setup value part of struct ns16550_priv"
> instead of "make it possible to get reg_write() from devtype";
> * add a trivial "fix whitespaces" patch.
>
>
> Antony Pavlov (8):
> MIPS: mach-xburst: fix DEBUG_LL=n build error
> MIPS: dts: rzx50: move jz4755 description to the separate file
> serial: ns16550: fix whitespaces
> serial: ns16550: make FCR setup value part of struct ns16550_priv
> serial: ns16550: add compatible entry for "ingenic,jz4740-uart"
> MIPS: rzx50: drop console initialization in board code
> MIPS: mach-xburst: drop serial.c
> MIPS: boards: rename rzx50 -> ritmix-rzx50
>
> Documentation/boards.dox | 2 +-
> arch/mips/Makefile | 2 +-
> arch/mips/boards/ritmix-rzx50/Makefile | 1 +
> .../ritmix-rzx50/include/board/board_pbl_start.h | 43 ++++++++++++++++
> .../boards/ritmix-rzx50/include/board/debug_ll.h | 23 +++++++++
> arch/mips/boards/ritmix-rzx50/ritmix-rzx50.dox | 46 +++++++++++++++++
> arch/mips/boards/ritmix-rzx50/serial.c | 27 ++++++++++
> arch/mips/boards/rzx50/Makefile | 1 -
> .../boards/rzx50/include/board/board_pbl_start.h | 43 ----------------
> arch/mips/boards/rzx50/include/board/debug_ll.h | 23 ---------
> arch/mips/boards/rzx50/rzx50.dox | 46 -----------------
> arch/mips/boards/rzx50/serial.c | 32 ------------
> arch/mips/configs/ritmix-rzx50_defconfig | 39 ++++++++++++++
> arch/mips/configs/rzx50_defconfig | 39 --------------
> arch/mips/dts/jz4755.dtsi | 35 +++++++++++++
> arch/mips/dts/rzx50.dts | 8 ++-
> arch/mips/include/asm/debug_ll_ns16550.h | 2 +
> arch/mips/mach-xburst/Makefile | 1 -
> arch/mips/mach-xburst/mach-xburst.dox | 2 +-
> arch/mips/mach-xburst/serial.c | 60 ----------------------
> drivers/serial/serial_ns16550.c | 35 ++++++++++---
> 21 files changed, 254 insertions(+), 256 deletions(-)
> create mode 100644 arch/mips/boards/ritmix-rzx50/Makefile
> create mode 100644 arch/mips/boards/ritmix-rzx50/include/board/board_pbl_start.h
> create mode 100644 arch/mips/boards/ritmix-rzx50/include/board/debug_ll.h
> create mode 100644 arch/mips/boards/ritmix-rzx50/ritmix-rzx50.dox
> create mode 100644 arch/mips/boards/ritmix-rzx50/serial.c
> delete mode 100644 arch/mips/boards/rzx50/Makefile
> delete mode 100644 arch/mips/boards/rzx50/include/board/board_pbl_start.h
> delete mode 100644 arch/mips/boards/rzx50/include/board/debug_ll.h
> delete mode 100644 arch/mips/boards/rzx50/rzx50.dox
> delete mode 100644 arch/mips/boards/rzx50/serial.c
> create mode 100644 arch/mips/configs/ritmix-rzx50_defconfig
> delete mode 100644 arch/mips/configs/rzx50_defconfig
> create mode 100644 arch/mips/dts/jz4755.dtsi
> delete mode 100644 arch/mips/mach-xburst/serial.c
>
> --
> 1.9.0
>
--
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-03-25 9:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 20:13 Antony Pavlov
2014-03-24 20:13 ` [PATCH v2 1/8] MIPS: mach-xburst: fix DEBUG_LL=n build error Antony Pavlov
2014-03-24 20:13 ` [PATCH v2 2/8] MIPS: dts: rzx50: move jz4755 description to the separate file Antony Pavlov
2014-03-24 20:13 ` [PATCH v2 3/8] serial: ns16550: fix whitespaces Antony Pavlov
2014-03-24 20:13 ` [PATCH v2 4/8] serial: ns16550: make FCR setup value part of struct ns16550_priv Antony Pavlov
2014-03-24 20:28 ` Antony Pavlov
2014-03-24 20:13 ` [PATCH v2 5/8] serial: ns16550: add compatible entry for "ingenic, jz4740-uart" Antony Pavlov
2014-03-24 20:13 ` [PATCH v2 6/8] MIPS: rzx50: drop console initialization in board code Antony Pavlov
2014-03-24 20:13 ` [PATCH v2 7/8] MIPS: mach-xburst: drop serial.c Antony Pavlov
2014-03-24 20:13 ` [PATCH v2 8/8] MIPS: boards: rename rzx50 -> ritmix-rzx50 Antony Pavlov
2014-03-25 9:40 ` Antony Pavlov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140325134040.c957f0ef648db46f734bfaf4@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox