* [PATCH] MIPS: mach-xburst: fix DEBUG_LL=n build error
@ 2014-03-26 8:29 Antony Pavlov
2014-03-28 8:00 ` Antony Pavlov
2014-03-28 9:06 ` Sascha Hauer
0 siblings, 2 replies; 3+ messages in thread
From: Antony Pavlov @ 2014-03-26 8:29 UTC (permalink / raw)
To: barebox
Here is my error log:
CC common/startup.o
In file included from arch/mips/mach-xburst/include/mach/debug_ll.h:25,
from include/debug_ll.h:31,
from common/startup.c:36:
arch/mips/include/asm/debug_ll_ns16550.h: In function 'PUTC_LL':
arch/mips/include/asm/debug_ll_ns16550.h:62: error: 'DEBUG_LL_UART_ADDR' undeclared (first use in this function)
arch/mips/include/asm/debug_ll_ns16550.h:62: error: (Each undeclared identifier is reported only once
arch/mips/include/asm/debug_ll_ns16550.h:62: error: for each function it appears in.)
make[1]: *** [common/startup.o] Error 1
Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
arch/mips/include/asm/debug_ll_ns16550.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/mips/include/asm/debug_ll_ns16550.h b/arch/mips/include/asm/debug_ll_ns16550.h
index f36010c..032f0a2 100644
--- a/arch/mips/include/asm/debug_ll_ns16550.h
+++ b/arch/mips/include/asm/debug_ll_ns16550.h
@@ -59,9 +59,11 @@
static __inline__ void PUTC_LL(char ch)
{
+#ifdef CONFIG_DEBUG_LL
while (!(__raw_readb((u8 *)DEBUG_LL_UART_ADDR + UART_LSR) & UART_LSR_THRE))
;
__raw_writeb(ch, (u8 *)DEBUG_LL_UART_ADDR + UART_THR);
+#endif /* CONFIG_DEBUG_LL */
}
#else /* __ASSEMBLY__ */
/*
--
1.9.0
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: mach-xburst: fix DEBUG_LL=n build error
2014-03-26 8:29 [PATCH] MIPS: mach-xburst: fix DEBUG_LL=n build error Antony Pavlov
@ 2014-03-28 8:00 ` Antony Pavlov
2014-03-28 9:06 ` Sascha Hauer
1 sibling, 0 replies; 3+ messages in thread
From: Antony Pavlov @ 2014-03-28 8:00 UTC (permalink / raw)
To: Sascha Hauer; +Cc: barebox
On Wed, 26 Mar 2014 12:29:25 +0400
Antony Pavlov <antonynpavlov@gmail.com> wrote:
ping
> Here is my error log:
>
> CC common/startup.o
> In file included from arch/mips/mach-xburst/include/mach/debug_ll.h:25,
> from include/debug_ll.h:31,
> from common/startup.c:36:
> arch/mips/include/asm/debug_ll_ns16550.h: In function 'PUTC_LL':
> arch/mips/include/asm/debug_ll_ns16550.h:62: error: 'DEBUG_LL_UART_ADDR' undeclared (first use in this function)
> arch/mips/include/asm/debug_ll_ns16550.h:62: error: (Each undeclared identifier is reported only once
> arch/mips/include/asm/debug_ll_ns16550.h:62: error: for each function it appears in.)
> make[1]: *** [common/startup.o] Error 1
>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
> arch/mips/include/asm/debug_ll_ns16550.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/mips/include/asm/debug_ll_ns16550.h b/arch/mips/include/asm/debug_ll_ns16550.h
> index f36010c..032f0a2 100644
> --- a/arch/mips/include/asm/debug_ll_ns16550.h
> +++ b/arch/mips/include/asm/debug_ll_ns16550.h
> @@ -59,9 +59,11 @@
>
> static __inline__ void PUTC_LL(char ch)
> {
> +#ifdef CONFIG_DEBUG_LL
> while (!(__raw_readb((u8 *)DEBUG_LL_UART_ADDR + UART_LSR) & UART_LSR_THRE))
> ;
> __raw_writeb(ch, (u8 *)DEBUG_LL_UART_ADDR + UART_THR);
> +#endif /* CONFIG_DEBUG_LL */
> }
> #else /* __ASSEMBLY__ */
> /*
> --
> 1.9.0
>
--
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: mach-xburst: fix DEBUG_LL=n build error
2014-03-26 8:29 [PATCH] MIPS: mach-xburst: fix DEBUG_LL=n build error Antony Pavlov
2014-03-28 8:00 ` Antony Pavlov
@ 2014-03-28 9:06 ` Sascha Hauer
1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2014-03-28 9:06 UTC (permalink / raw)
To: Antony Pavlov; +Cc: barebox
On Wed, Mar 26, 2014 at 12:29:25PM +0400, Antony Pavlov wrote:
> Here is my error log:
>
> CC common/startup.o
> In file included from arch/mips/mach-xburst/include/mach/debug_ll.h:25,
> from include/debug_ll.h:31,
> from common/startup.c:36:
> arch/mips/include/asm/debug_ll_ns16550.h: In function 'PUTC_LL':
> arch/mips/include/asm/debug_ll_ns16550.h:62: error: 'DEBUG_LL_UART_ADDR' undeclared (first use in this function)
> arch/mips/include/asm/debug_ll_ns16550.h:62: error: (Each undeclared identifier is reported only once
> arch/mips/include/asm/debug_ll_ns16550.h:62: error: for each function it appears in.)
> make[1]: *** [common/startup.o] Error 1
>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
Applied, thanks
Sascha
> ---
> arch/mips/include/asm/debug_ll_ns16550.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/mips/include/asm/debug_ll_ns16550.h b/arch/mips/include/asm/debug_ll_ns16550.h
> index f36010c..032f0a2 100644
> --- a/arch/mips/include/asm/debug_ll_ns16550.h
> +++ b/arch/mips/include/asm/debug_ll_ns16550.h
> @@ -59,9 +59,11 @@
>
> static __inline__ void PUTC_LL(char ch)
> {
> +#ifdef CONFIG_DEBUG_LL
> while (!(__raw_readb((u8 *)DEBUG_LL_UART_ADDR + UART_LSR) & UART_LSR_THRE))
> ;
> __raw_writeb(ch, (u8 *)DEBUG_LL_UART_ADDR + UART_THR);
> +#endif /* CONFIG_DEBUG_LL */
> }
> #else /* __ASSEMBLY__ */
> /*
> --
> 1.9.0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-28 9:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-26 8:29 [PATCH] MIPS: mach-xburst: fix DEBUG_LL=n build error Antony Pavlov
2014-03-28 8:00 ` Antony Pavlov
2014-03-28 9:06 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox