From: Antony Pavlov <antonynpavlov@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] MIPS: mach-xburst: fix DEBUG_LL=n build error
Date: Fri, 28 Mar 2014 12:00:00 +0400 [thread overview]
Message-ID: <20140328120000.7a6b0bbc99ec261bd6c88c67@gmail.com> (raw)
In-Reply-To: <1395822565-14283-1-git-send-email-antonynpavlov@gmail.com>
On Wed, 26 Mar 2014 12:29:25 +0400
Antony Pavlov <antonynpavlov@gmail.com> wrote:
ping
> Here is my error log:
>
> CC common/startup.o
> In file included from arch/mips/mach-xburst/include/mach/debug_ll.h:25,
> from include/debug_ll.h:31,
> from common/startup.c:36:
> arch/mips/include/asm/debug_ll_ns16550.h: In function 'PUTC_LL':
> arch/mips/include/asm/debug_ll_ns16550.h:62: error: 'DEBUG_LL_UART_ADDR' undeclared (first use in this function)
> arch/mips/include/asm/debug_ll_ns16550.h:62: error: (Each undeclared identifier is reported only once
> arch/mips/include/asm/debug_ll_ns16550.h:62: error: for each function it appears in.)
> make[1]: *** [common/startup.o] Error 1
>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
> arch/mips/include/asm/debug_ll_ns16550.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/mips/include/asm/debug_ll_ns16550.h b/arch/mips/include/asm/debug_ll_ns16550.h
> index f36010c..032f0a2 100644
> --- a/arch/mips/include/asm/debug_ll_ns16550.h
> +++ b/arch/mips/include/asm/debug_ll_ns16550.h
> @@ -59,9 +59,11 @@
>
> static __inline__ void PUTC_LL(char ch)
> {
> +#ifdef CONFIG_DEBUG_LL
> while (!(__raw_readb((u8 *)DEBUG_LL_UART_ADDR + UART_LSR) & UART_LSR_THRE))
> ;
> __raw_writeb(ch, (u8 *)DEBUG_LL_UART_ADDR + UART_THR);
> +#endif /* CONFIG_DEBUG_LL */
> }
> #else /* __ASSEMBLY__ */
> /*
> --
> 1.9.0
>
--
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-03-28 7:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-26 8:29 Antony Pavlov
2014-03-28 8:00 ` Antony Pavlov [this message]
2014-03-28 9:06 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140328120000.7a6b0bbc99ec261bd6c88c67@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox