From: Sascha Hauer <s.hauer@pengutronix.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 5/5] video: imx-ipu-v3: fix possible NULL ptr dereference
Date: Wed, 23 Apr 2014 09:20:40 +0200 [thread overview]
Message-ID: <20140423072040.GA5858@pengutronix.de> (raw)
In-Reply-To: <CAOMZO5Aka_=iyA=qUf+_1s9dyxpNpf6DxwWPq=62hZBxsKLkKQ@mail.gmail.com>
On Mon, Apr 21, 2014 at 05:43:46PM -0300, Fabio Estevam wrote:
> On Mon, Apr 21, 2014 at 5:15 PM, Lucas Stach <dev@lynxeye.de> wrote:
> > Signed-off-by: Lucas Stach <dev@lynxeye.de>
> > ---
> > drivers/video/imx-ipu-v3/ipu-dmfc.c | 10 ++++++----
> > 1 file changed, 6 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/video/imx-ipu-v3/ipu-dmfc.c b/drivers/video/imx-ipu-v3/ipu-dmfc.c
> > index 7b54e25001c6..61704f4a9c06 100644
> > --- a/drivers/video/imx-ipu-v3/ipu-dmfc.c
> > +++ b/drivers/video/imx-ipu-v3/ipu-dmfc.c
> > @@ -146,16 +146,18 @@ EXPORT_SYMBOL_GPL(ipu_dmfc_disable_channel);
> > static int ipu_dmfc_setup_channel(struct dmfc_channel *dmfc, int slots,
> > int segment, int burstsize)
> > {
> > - struct ipu_dmfc_priv *priv = dmfc->priv;
> > + struct ipu_dmfc_priv *priv;
> > u32 val, field;
> >
> > + if (!dmfc)
> > + return -EINVAL;
>
> Would be better to fix it in the same way we did in the kernel:
> http://www.spinics.net/lists/linux-driver-devel/msg45096.html
Just did that and applied this series.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-04-23 7:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 20:15 [PATCH 1/5] treewide: fix signedness mixups in printf format specifiers Lucas Stach
2014-04-21 20:15 ` [PATCH 2/5] ARM: at91: add missing break Lucas Stach
2014-04-22 1:14 ` Bo Shen
2014-04-21 20:15 ` [PATCH 3/5] imx-image: don't leak file handle Lucas Stach
2014-04-21 20:15 ` [PATCH 4/5] video: displaytimings: remove two broken error messages Lucas Stach
2014-04-21 20:15 ` [PATCH 5/5] video: imx-ipu-v3: fix possible NULL ptr dereference Lucas Stach
2014-04-21 20:43 ` Fabio Estevam
2014-04-23 7:20 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423072040.GA5858@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=festevam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox