From: Alexander Aring <alex.aring@gmail.com>
To: Christian Hemp <c.hemp@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 4/4] imx6: Add support for phyCARD-i.MX6
Date: Fri, 25 Apr 2014 15:10:04 +0200 [thread overview]
Message-ID: <20140425130834.GA29115@omega> (raw)
In-Reply-To: <1398426868-30285-4-git-send-email-c.hemp@phytec.de>
Hi,
On Fri, Apr 25, 2014 at 01:54:28PM +0200, Christian Hemp wrote:
> Add support for Phytec phyCARD-i.MX6.
> - 1GB RAM on two banks
> - 1GB RAM on one bank
> - 2GB RAM on two banks
...
> +
> +extern char __dtb_imx6q_phytec_pbaa03_start[];
> +
> +ENTRY_FUNCTION(start_phytec_pbaa03_1gib, r0, r1, r2)
> +{
> + uint32_t fdt;
> +
> + arm_cpu_lowlevel_init();
> +
> + arm_setup_stack(0x00920000 - 8);
> +
> + if (IS_ENABLED(CONFIG_DEBUG_LL))
> + setup_uart();
> +
> + fdt = (uint32_t)__dtb_imx6q_phytec_pbaa03_start - get_runtime_offset();
> +
> + barebox_arm_entry(0x10000000, SZ_1G, fdt);
> +}
> +
> +ENTRY_FUNCTION(start_phytec_pbaa03_1gib_1bank, r0, r1, r2)
> +{
> + uint32_t fdt;
> +
> + arm_cpu_lowlevel_init();
> +
> + arm_setup_stack(0x00920000 - 8);
> +
> + if (IS_ENABLED(CONFIG_DEBUG_LL))
> + setup_uart();
> +
> + fdt = (uint32_t)__dtb_imx6q_phytec_pbaa03_start - get_runtime_offset();
> +
> + barebox_arm_entry(0x10000000, SZ_1G, fdt);
> +}
> +
Don't see a difference between start_phytec_pbaa03_1gib_1bank and
start_phytec_pbaa03_1gib. Maybe you can write a new function and these
two functions can call this function...
It's a design question...
- Alex
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-04-25 13:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 11:54 [PATCH 1/4] imx6:mmdc: Move register defines to header file Christian Hemp
2014-04-25 11:54 ` [PATCH 2/4] imx6: read back memory size Christian Hemp
2014-04-25 11:54 ` [PATCH 3/4] dts: imx6qdl: add ethernet pin group for mii Christian Hemp
2014-04-25 13:02 ` Lucas Stach
2014-04-25 11:54 ` [PATCH 4/4] imx6: Add support for phyCARD-i.MX6 Christian Hemp
2014-04-25 13:10 ` Alexander Aring [this message]
2014-04-25 13:16 ` Lucas Stach
2014-04-25 13:22 ` Alexander Aring
2014-04-28 13:58 ` Christian Hemp
2014-04-28 14:15 ` Sascha Hauer
2014-04-27 6:38 ` Sascha Hauer
2014-04-25 12:54 ` [PATCH 1/4] imx6:mmdc: Move register defines to header file Alexander Aring
2014-04-25 12:57 ` Alexander Aring
2014-04-26 15:00 ` Alexander Aring
2014-04-28 6:10 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140425130834.GA29115@omega \
--to=alex.aring@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=c.hemp@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox