mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] video: imx-ipu-v3: Fix ipu_ch_param_zero()
Date: Sun, 27 Apr 2014 08:52:07 +0200	[thread overview]
Message-ID: <20140427065207.GI5858@pengutronix.de> (raw)
In-Reply-To: <1398580187-4950-1-git-send-email-shc_work@mail.ru>

On Sun, Apr 27, 2014 at 10:29:47AM +0400, Alexander Shiyan wrote:
> Sizeof(*p) returns the size of the pointer, not the size of the
> struct ipu_ch_param.

p is of type struct ipu_ch_param, so sizeof(*p) correctly returns the
size of struct ipu_ch_param.

Sascha

> 
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
>  drivers/video/imx-ipu-v3/imx-ipu-v3.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/imx-ipu-v3/imx-ipu-v3.h b/drivers/video/imx-ipu-v3/imx-ipu-v3.h
> index 7c48a7c..39255be 100644
> --- a/drivers/video/imx-ipu-v3/imx-ipu-v3.h
> +++ b/drivers/video/imx-ipu-v3/imx-ipu-v3.h
> @@ -241,7 +241,7 @@ static inline void ipu_ch_param_zero(struct ipu_ch_param __iomem *p)
>  	int i;
>  	void __iomem *base = p;
>  
> -	for (i = 0; i < sizeof(*p) / sizeof(u32); i++)
> +	for (i = 0; i < sizeof(struct ipu_ch_param) / sizeof(u32); i++)
>  		ipuwritel("chp", 0, base + i * sizeof(u32));
>  }
>  
> -- 
> 1.8.3.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2014-04-27  6:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-27  6:29 Alexander Shiyan
2014-04-27  6:52 ` Sascha Hauer [this message]
2014-04-27 14:44   ` Alexander Shiyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140427065207.GI5858@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=shc_work@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox