[PATCH] video: imx-ipu-v3: Fix ipu_ch_param_zero()

[PATCH] video: imx-ipu-v3: Fix ipu_ch_param_zero()

[Alexander Shiyan]

Sizeof(*p) returns the size of the pointer, not the size of the
struct ipu_ch_param.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 drivers/video/imx-ipu-v3/imx-ipu-v3.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/imx-ipu-v3/imx-ipu-v3.h b/drivers/video/imx-ipu-v3/imx-ipu-v3.h
index 7c48a7c..39255be 100644
--- a/drivers/video/imx-ipu-v3/imx-ipu-v3.h
+++ b/drivers/video/imx-ipu-v3/imx-ipu-v3.h
@@ -241,7 +241,7 @@ static inline void ipu_ch_param_zero(struct ipu_ch_param __iomem *p)
 	int i;
 	void __iomem *base = p;
 
-	for (i = 0; i < sizeof(*p) / sizeof(u32); i++)
+	for (i = 0; i < sizeof(struct ipu_ch_param) / sizeof(u32); i++)
 		ipuwritel("chp", 0, base + i * sizeof(u32));
 }
 
-- 
1.8.3.2


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] video: imx-ipu-v3: Fix ipu_ch_param_zero()

[Sascha Hauer]

On Sun, Apr 27, 2014 at 10:29:47AM +0400, Alexander Shiyan wrote:
> Sizeof(*p) returns the size of the pointer, not the size of the
> struct ipu_ch_param.

p is of type struct ipu_ch_param, so sizeof(*p) correctly returns the
size of struct ipu_ch_param.

Sascha

> 
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
>  drivers/video/imx-ipu-v3/imx-ipu-v3.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/imx-ipu-v3/imx-ipu-v3.h b/drivers/video/imx-ipu-v3/imx-ipu-v3.h
> index 7c48a7c..39255be 100644
> --- a/drivers/video/imx-ipu-v3/imx-ipu-v3.h
> +++ b/drivers/video/imx-ipu-v3/imx-ipu-v3.h
> @@ -241,7 +241,7 @@ static inline void ipu_ch_param_zero(struct ipu_ch_param __iomem *p)
>  	int i;
>  	void __iomem *base = p;
>  
> -	for (i = 0; i < sizeof(*p) / sizeof(u32); i++)
> +	for (i = 0; i < sizeof(struct ipu_ch_param) / sizeof(u32); i++)
>  		ipuwritel("chp", 0, base + i * sizeof(u32));
>  }
>  
> -- 
> 1.8.3.2
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] video: imx-ipu-v3: Fix ipu_ch_param_zero()

[Alexander Shiyan]

Sun, 27 Apr 2014 08:52:07 +0200 от Sascha Hauer <s.hauer@pengutronix.de>:
> On Sun, Apr 27, 2014 at 10:29:47AM +0400, Alexander Shiyan wrote:
> > Sizeof(*p) returns the size of the pointer, not the size of the
> > struct ipu_ch_param.
> 
> p is of type struct ipu_ch_param, so sizeof(*p) correctly returns the
> size of struct ipu_ch_param.

Seems this is my mistake...

---

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox