From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WemLW-0003MA-Uy for barebox@lists.infradead.org; Mon, 28 Apr 2014 14:15:51 +0000 Date: Mon, 28 Apr 2014 16:15:29 +0200 From: Sascha Hauer Message-ID: <20140428141529.GT5858@pengutronix.de> References: <1398426868-30285-1-git-send-email-c.hemp@phytec.de> <1398426868-30285-4-git-send-email-c.hemp@phytec.de> <20140425130834.GA29115@omega> <1398431808.4657.35.camel@weser.hi.pengutronix.de> <1398693501.5448.25.camel@lws-hemp> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1398693501.5448.25.camel@lws-hemp> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 4/4] imx6: Add support for phyCARD-i.MX6 To: Christian Hemp Cc: barebox@lists.infradead.org On Mon, Apr 28, 2014 at 03:58:21PM +0200, Christian Hemp wrote: > Hi, > Am Freitag, den 25.04.2014, 15:16 +0200 schrieb Lucas Stach: > > Am Freitag, den 25.04.2014, 15:10 +0200 schrieb Alexander Aring: > > > Hi, > > > > > > On Fri, Apr 25, 2014 at 01:54:28PM +0200, Christian Hemp wrote: > > > > Add support for Phytec phyCARD-i.MX6. > > > > - 1GB RAM on two banks > > > > - 1GB RAM on one bank > > > > - 2GB RAM on two banks > > > ... > > > > + > > > > +extern char __dtb_imx6q_phytec_pbaa03_start[]; > > > > + > > > > +ENTRY_FUNCTION(start_phytec_pbaa03_1gib, r0, r1, r2) > > > > +{ > > > > + uint32_t fdt; > > > > + > > > > + arm_cpu_lowlevel_init(); > > > > + > > > > + arm_setup_stack(0x00920000 - 8); > > > > + > > > > + if (IS_ENABLED(CONFIG_DEBUG_LL)) > > > > + setup_uart(); > > > > + > > > > + fdt = (uint32_t)__dtb_imx6q_phytec_pbaa03_start - get_runtime_offset(); > > > > + > > > > + barebox_arm_entry(0x10000000, SZ_1G, fdt); > > > > +} > > > > + > > > > +ENTRY_FUNCTION(start_phytec_pbaa03_1gib_1bank, r0, r1, r2) > > > > +{ > > > > + uint32_t fdt; > > > > + > > > > + arm_cpu_lowlevel_init(); > > > > + > > > > + arm_setup_stack(0x00920000 - 8); > > > > + > > > > + if (IS_ENABLED(CONFIG_DEBUG_LL)) > > > > + setup_uart(); > > > > + > > > > + fdt = (uint32_t)__dtb_imx6q_phytec_pbaa03_start - get_runtime_offset(); > > > > + > > > > + barebox_arm_entry(0x10000000, SZ_1G, fdt); > > > > +} > > > > + > > > > > > Don't see a difference between start_phytec_pbaa03_1gib_1bank and > > > start_phytec_pbaa03_1gib. Maybe you can write a new function and these > > > two functions can call this function... > > > > > > It's a design question... > > > > > If those two are really meant to be the same, you don't even need two > > entry functions. Just build a single PBL and add different DCDs through > > the image mechanism. > > I tried it with one entry function but I get no positive result. > The only two results I get was, wrong memory initialization and a build > error. > > What do I need to change in the following lines to use a single PBL and > different DCDs for both memory versions? > > pblx-$(CONFIG_MACH_PCAAXL3) += start_phytec_pbaa03_1gib > CFG_start_phytec_pbaa03_1gib.pblx.imximg = > $(board)/phytec-phycard-imx6/flash-header-phytec-pcaaxl3-1gib.imxcfg > FILE_barebox-phytec-pbaa03-1gib.img = What Lucas suggested doesn't work because .imxcfg filename is generated from the image name which in turn is generated from the entry function name. I think it's ok the way you did it. Or make Lucas come up with a way to come by this limitation ;) Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox