From: Sascha Hauer <s.hauer@pengutronix.de>
To: Alexander Aring <alex.aring@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] Add initial regulator support
Date: Mon, 28 Apr 2014 22:00:30 +0200 [thread overview]
Message-ID: <20140428200030.GY5858@pengutronix.de> (raw)
In-Reply-To: <20140428185119.GA11686@omega>
On Mon, Apr 28, 2014 at 08:51:21PM +0200, Alexander Aring wrote:
> Hi,
>
> On Mon, Apr 28, 2014 at 08:47:02PM +0200, Sascha Hauer wrote:
> >
> > I think both functions should return 0 without a valid gpio instead.
> > Anyway, there's something wrong here.
> >
>
> maybe checking on this at probe time, at the beginning or can this gpio
> changed at runtime?
>
> Maybe you don't need this here because probe will already failed with a
> invalid gpio.
No, the gpio is optional. Getting a fixed regulator without software
control is one usecase of the driver, just like in the kernel.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-04-28 20:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 8:18 [PATCH] " Sascha Hauer
2014-04-28 8:18 ` [PATCH 1/2] Add " Sascha Hauer
2014-04-28 16:30 ` Alexander Aring
2014-04-28 16:41 ` Alexander Aring
2014-04-28 18:47 ` Sascha Hauer
2014-04-28 18:51 ` Alexander Aring
2014-04-28 20:00 ` Sascha Hauer [this message]
2014-04-28 20:08 ` Alexander Aring
2014-04-28 8:18 ` [PATCH 2/2] mci: Add " Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140428200030.GY5858@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=alex.aring@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox