From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Michael D. Burkey" <mdburkey@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/1] Fix bug in export 64 bit unsigned environment variable.
Date: Wed, 30 Apr 2014 08:56:05 +0200 [thread overview]
Message-ID: <20140430065605.GF5858@pengutronix.de> (raw)
In-Reply-To: <CAO6XYUsjR_GdrkFHT2wy=4Lg-yosH8hKb3d2_Euoz8uY+3kQpQ@mail.gmail.com>
On Tue, Apr 29, 2014 at 03:16:02PM -0400, Michael D. Burkey wrote:
> This patch corrects exporting unsigned 64-bit environment variables.
> I had left out a signed off line before.
>
> Signed-off-by: Michael Burkey <mdburkey at gmail.com>
Applied, thanks
Sascha
> ---
>
>
> --- a/common/env.c
> +++ b/common/env.c
> @@ -258,7 +258,7 @@
>
> void export_env_ull(const char *name, unsigned long long val)
> {
> - char *valstr = asprintf("%lld", val);
> + char *valstr = asprintf("%llu", val);
>
> setenv(name, valstr);
> export(name);
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-04-30 6:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 19:16 Michael D. Burkey
2014-04-30 6:56 ` Sascha Hauer [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-04-10 20:16 Michael D. Burkey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140430065605.GF5858@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=mdburkey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox