[PATCH 1/1] Fix bug in export 64 bit unsigned environment variable.

[PATCH 1/1] Fix bug in export 64 bit unsigned environment variable.

[Michael D. Burkey]

This patch corrects exporting unsigned 64-bit environment variables.
I had left out a signed off line before.

Signed-off-by: Michael Burkey <mdburkey at gmail.com>
---


--- a/common/env.c
+++ b/common/env.c
@@ -258,7 +258,7 @@

 void export_env_ull(const char *name, unsigned long long val)
 {
-       char *valstr = asprintf("%lld", val);
+       char *valstr = asprintf("%llu", val);

        setenv(name, valstr);
        export(name);

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH 1/1] Fix bug in export 64 bit unsigned environment variable.

[Sascha Hauer]

On Tue, Apr 29, 2014 at 03:16:02PM -0400, Michael D. Burkey wrote:
> This patch corrects exporting unsigned 64-bit environment variables.
> I had left out a signed off line before.
> 
> Signed-off-by: Michael Burkey <mdburkey at gmail.com>

Applied, thanks

Sascha

> ---
> 
> 
> --- a/common/env.c
> +++ b/common/env.c
> @@ -258,7 +258,7 @@
> 
>  void export_env_ull(const char *name, unsigned long long val)
>  {
> -       char *valstr = asprintf("%lld", val);
> +       char *valstr = asprintf("%llu", val);
> 
>         setenv(name, valstr);
>         export(name);
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

[PATCH 1/1] Fix bug in export 64 bit unsigned environment variable.

[Michael D. Burkey]

(As this is the first patch I'm posting directly to the list rather
than through Sascha, feel free to yell at me if my format is wrong.)

This fixes a fairly major, trivial bug in the export_env_ull function
-- it is currently converting values to signed when it exports them.
As the import function doesn't handle signed values, this means that
any values with the msb set cannot be read back in -- which breaks
some things like passing serial # ATAG's to the kernel.

This simple (one character!) fix solves the problem.

Michael D. Burkey

-------------------------------------------------------------------------

--- a/common/env.c
+++ b/common.env.c
@@ -258,7 +258,7 @@

 void export_env_ull(const char *name, unsigned long long val)
 {
-	char *valstr = asprintf("%lld", val);
+	char *valstr = asprintf("%llu", val);

 	setenv(name, valstr);
 	export(name);

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox