From: Sascha Hauer <s.hauer@pengutronix.de>
To: chf.fritz@googlemail.com
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/3] net cpsw: fix rx stability under heavy network load
Date: Mon, 5 May 2014 09:21:00 +0200 [thread overview]
Message-ID: <20140505072100.GS5858@pengutronix.de> (raw)
In-Reply-To: <5360b519.c62a980a.05b6.526d@mx.google.com>
On Wed, Apr 30, 2014 at 10:32:02AM +0200, chf.fritz@googlemail.com wrote:
> From: Christoph Fritz <chf.fritz@googlemail.com>
>
> RX DMA Head Descriptor Pointer can get 0 when there is a lot of traffic,
> which results in a timeout error. A good way to provoke this error is by
> sending lots of ARP requests. This patch makes sure that the RX DMA Head
> Descriptor Pointer is set.
>
> The origin driver, from which this is derived, already contains this fix.
>
> Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
Nice fix, thanks. I also stumbled upon this.
Applied
Sascha
> ---
> drivers/net/cpsw.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/cpsw.c b/drivers/net/cpsw.c
> index 52adf50..ec3263d 100644
> --- a/drivers/net/cpsw.c
> +++ b/drivers/net/cpsw.c
> @@ -741,8 +741,13 @@ static int cpdma_process(struct cpsw_priv *priv, struct cpdma_chan *chan,
> if (buffer)
> *buffer = (void *)readl(&desc->sw_buffer);
>
> - if (status & CPDMA_DESC_OWNER)
> + if (status & CPDMA_DESC_OWNER) {
> + if (readl(chan->hdp) == 0) {
> + if (readl(&desc->hw_mode) & CPDMA_DESC_OWNER)
> + writel((u32)desc, chan->hdp);
> + }
> return -EBUSY;
> + }
>
> chan->head = (void *)readl(&desc->hw_next);
>
> --
> 1.7.10.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-05-05 7:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1398846723-10241-1-git-send-email-y>
2014-04-30 8:32 ` [PATCH 1/3] tftp: add timeframe when remote server is retransmitting chf.fritz
2014-05-05 7:20 ` Sascha Hauer
2014-04-30 8:32 ` [PATCH 2/3] net cpsw: fix rx stability under heavy network load chf.fritz
2014-05-05 7:21 ` Sascha Hauer [this message]
2014-04-30 8:32 ` [PATCH 3/3] net cpsw: check phy status on send and receive chf.fritz
2014-05-05 7:22 ` Sascha Hauer
2014-05-05 8:36 ` Christoph Fritz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140505072100.GS5858@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=chf.fritz@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox