mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Franck Jullien <franck.jullien@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] openrisc: move ethoc registration to device_initcall
Date: Mon, 12 May 2014 06:40:59 +0200	[thread overview]
Message-ID: <20140512044059.GX5858@pengutronix.de> (raw)
In-Reply-To: <1399761724-4109-1-git-send-email-franck.jullien@gmail.com>

On Sun, May 11, 2014 at 12:42:04AM +0200, Franck Jullien wrote:
> Signed-off-by: Franck Jullien <franck.jullien@gmail.com>
> ---
>  arch/openrisc/boards/generic/generic.c |   18 ++++++++++++------
>  1 files changed, 12 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/openrisc/boards/generic/generic.c b/arch/openrisc/boards/generic/generic.c
> index 9f68007..5c1698d 100644
> --- a/arch/openrisc/boards/generic/generic.c
> +++ b/arch/openrisc/boards/generic/generic.c
> @@ -9,6 +9,18 @@ static struct NS16550_plat serial_plat = {
>  	.shift = 0,
>  };
>  
> +static int openrisc_devices_init(void)
> +{
> +#ifdef CONFIG_DRIVER_NET_ETHOC
> +	add_generic_device("ethoc", DEVICE_ID_DYNAMIC, NULL,
> +			   OPENRISC_SOPC_ETHOC_BASE, 0x1000,
> +			   IORESOURCE_MEM, NULL);
> +#endif
> +	return 0;
> +}
> +
> +device_initcall(openrisc_devices_init);

What's wrong with the original console_initcall? Does this solve any
issues?

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2014-05-12  4:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-10 22:42 Franck Jullien
2014-05-12  4:40 ` Sascha Hauer [this message]
2014-05-12  7:49   ` Franck Jullien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140512044059.GX5858@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=franck.jullien@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox