From: Sascha Hauer <s.hauer@pengutronix.de>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] syscon: fix prototype compile error
Date: Fri, 16 May 2014 08:04:41 +0200 [thread overview]
Message-ID: <20140516060441.GS5858@pengutronix.de> (raw)
In-Reply-To: <1400166036-31135-1-git-send-email-l.stach@pengutronix.de>
On Thu, May 15, 2014 at 05:00:36PM +0200, Lucas Stach wrote:
> From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
>
> gcc 4.8.3 throws the following error
>
> include/mfd/syscon.h: In function 'syscon_base_lookup_by_pdevname':
> include/mfd/syscon.h:22:1: error: parameter name omitted
> static inline void __iomem *syscon_base_lookup_by_pdevname(const char *)
>
> Fix it by adding the name to the function prototype.
>
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Applied, thanks
Sascha
> ---
> include/mfd/syscon.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/mfd/syscon.h b/include/mfd/syscon.h
> index 0eccd5cb5d84..20445202b252 100644
> --- a/include/mfd/syscon.h
> +++ b/include/mfd/syscon.h
> @@ -15,11 +15,11 @@
> #define __MFD_SYSCON_H__
>
> #ifdef CONFIG_MFD_SYSCON
> -void __iomem *syscon_base_lookup_by_pdevname(const char *);
> +void __iomem *syscon_base_lookup_by_pdevname(const char *s);
> void __iomem *syscon_base_lookup_by_phandle
> (struct device_node *np, const char *property);
> #else
> -static inline void __iomem *syscon_base_lookup_by_pdevname(const char *)
> +static inline void __iomem *syscon_base_lookup_by_pdevname(const char *s)
> {
> return NULL;
> }
> --
> 2.0.0.rc0
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-05-16 6:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 15:00 Lucas Stach
2014-05-16 6:04 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140516060441.GS5858@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=l.stach@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox