From: Sascha Hauer <s.hauer@pengutronix.de>
To: Marc Reilly <marc@cpdesign.com.au>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/5] mfd: mc13xxx: Allow to set callback for mc13xxx
Date: Mon, 19 May 2014 08:40:34 +0200 [thread overview]
Message-ID: <20140519064034.GY5858@pengutronix.de> (raw)
In-Reply-To: <1457646.XTgHtzepJG@dev2>
Hi MArc,
On Mon, May 19, 2014 at 09:14:19AM +1000, Marc Reilly wrote:
> Hi,
>
> I'm a bit slow on this one, so sorry if I'm too late to the party. :)
Don't worry, you're not too late.
> >
> > +void(*mc13xxx_callback)(struct mc13xxx *mc13xxx);
>
>
> Should (can?) this be static?
Yes, it should. fixed.
> > +int mc13xxx_register_callback(void(*callback)(struct mc13xxx *mc13xxx))
>
>
> What about mc13xxx_register_init_callback, or something which makes it more
> apparent when the callback is called.
Indeed that's a better name.
> > diff --git a/drivers/net/fec_imx.h b/drivers/net/fec_imx.h
> > index 0921b52..a77c1dc 100644
> > --- a/drivers/net/fec_imx.h
> > +++ b/drivers/net/fec_imx.h
> > @@ -146,6 +146,7 @@ struct fec_priv {
> > void (*phy_init)(struct phy_device *dev);
> > struct clk *clk;
> > enum fec_type type;
> > + int phy_reset_gpio;
>
>
> Did this sneak in?
Oops. Fixed.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-05-19 6:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 7:31 [PATCH] fix i.MX51 babbage ethernet Sascha Hauer
2014-05-08 7:31 ` [PATCH 1/5] mfd: mc13xxx: Allow to set callback for mc13xxx Sascha Hauer
2014-05-18 23:14 ` Marc Reilly
2014-05-19 6:40 ` Sascha Hauer [this message]
2014-05-08 7:31 ` [PATCH 2/5] spi: i.MX: Move to coredevice_initcall Sascha Hauer
2014-05-11 18:49 ` Alexander Shiyan
2014-05-12 10:38 ` Sascha Hauer
2014-05-14 17:57 ` Alexander Shiyan
2014-05-19 8:47 ` Sascha Hauer
2014-05-08 7:31 ` [PATCH 3/5] mfd: mc13xxx: move " Sascha Hauer
2014-05-08 7:31 ` [PATCH 4/5] ARM: i.MX51 babbage: use mc13xxx_register_callback to initialize PMIC Sascha Hauer
2014-05-08 7:31 ` [PATCH 5/5] ARM: dts: i.MX51 babbage: overwrite upstream FEC iomux settings Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140519064034.GY5858@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=marc@cpdesign.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox