From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: Kristof Roelants <kristof.roelants@tass.be>,
barebox <barebox@lists.infradead.org>,
Daniele Lacamera <daniele.lacamera@tass.be>,
Daniele Lacamera <mlists@danielinux.net>,
Sam Van Den Berge <sam.van.den.berge@tass.be>
Subject: Re: [RFC] [WIP] incorporate picotcp into barebox: a small demo
Date: Wed, 28 May 2014 08:08:59 +0200 [thread overview]
Message-ID: <20140528060859.GO15686@pengutronix.de> (raw)
In-Reply-To: <20140527180411.9c1c650b8e9d19fdcec7614d@gmail.com>
On Tue, May 27, 2014 at 06:04:11PM +0400, Antony Pavlov wrote:
> On Tue, 27 May 2014 11:46:29 +0200
> Daniele Lacamera <daniele.lacamera@tass.be> wrote:
>
> $ gcc --version
> gcc (Debian 4.8.3-1) 4.8.3
>
> Here is my 'make -s' output for sandbox barebox:
>
> net/picotcp/modules/pico_ipv4.c: In function ‘pico_ipv4_rebound_large’:
> net/picotcp/modules/pico_ipv4.c:1582:24: warning: unused variable ‘fr’ [-Wunused-variable]
> struct pico_frame *fr;
> ^
> net/picotcp/modules/pico_ipv4.c:1581:14: warning: unused variable ‘len’ [-Wunused-variable]
> uint32_t len = f->transport_len;
> ^
> net/picotcp/modules/pico_ipv4.c:1580:14: warning: unused variable ‘total_payload_written’ [-Wunused-variable]
> uint32_t total_payload_written = 0;
> ^
That's another advantage of IS_ENABLED. This happens because the variables are
only used under an ifdef. Fixing this would mean to put the definitions under
the same ifdef which requires another ifdef.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-05-28 6:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-25 9:58 Antony Pavlov
2014-05-26 9:35 ` Daniele Lacamera
2014-05-26 9:45 ` Lucas Stach
2014-05-26 12:09 ` Antony Pavlov
2014-05-27 5:30 ` Sascha Hauer
2014-05-27 7:52 ` Daniele Lacamera
2014-05-27 9:46 ` Daniele Lacamera
2014-05-27 14:04 ` Antony Pavlov
2014-05-27 17:26 ` Daniele Lacamera
2014-05-29 5:40 ` Antony Pavlov
2014-05-28 6:08 ` Sascha Hauer [this message]
2014-05-28 7:23 ` Juergen Borleis
2014-05-28 10:32 ` Antony Pavlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140528060859.GO15686@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=daniele.lacamera@tass.be \
--cc=kristof.roelants@tass.be \
--cc=mlists@danielinux.net \
--cc=sam.van.den.berge@tass.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox