From: Sascha Hauer <s.hauer@pengutronix.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
"barebox@lists.infradead.org" <barebox@lists.infradead.org>,
Eric Nelson <eric.nelson@boundarydevices.com>
Subject: Re: [PATCH] serial: imx: Fix buggy transmissions when baudrate mismatches
Date: Mon, 2 Jun 2014 09:22:36 +0200 [thread overview]
Message-ID: <20140602072236.GV15686@pengutronix.de> (raw)
In-Reply-To: <CAOMZO5DUtJu962JEbSBMRQMxVkZDD+rYVmr0Ajgfavx7+qgdww@mail.gmail.com>
On Wed, May 28, 2014 at 04:57:18PM -0300, Fabio Estevam wrote:
> On Thu, May 15, 2014 at 7:05 PM, Fabio Estevam <festevam@gmail.com> wrote:
> > Hi Sascha,
> >
> > On Thu, May 15, 2014 at 6:21 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> >
> >>> --- a/drivers/serial/serial_imx.c
> >>> +++ b/drivers/serial/serial_imx.c
> >>> @@ -258,7 +258,8 @@ static int imx_serial_getc(struct console_device *cdev)
> >>> while (readl(priv->regs + priv->devtype->uts) & UTS_RXEMPTY);
> >>>
> >>> ch = readl(priv->regs + URXD0);
> >>> -
> >>> + if (ch >= 0x80)
> >>> + ch = '?';
> >>
> >> This is not part of the fix, right?
> >
> > Correct, this is not part of the fix.
> >
> > This code is just to help reproducing the issue in console, without
> > the need of hooking an oscilloscope to the UART pins or inspecting
> > directly the UART TX registers.
>
> Any comments, Sascha?
No, I assumed you resend the patch without the hunk above.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-06-02 7:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 18:14 Fabio Estevam
2014-05-15 21:21 ` Sascha Hauer
2014-05-15 22:05 ` Fabio Estevam
2014-05-28 19:57 ` Fabio Estevam
2014-06-02 7:22 ` Sascha Hauer [this message]
2014-06-02 10:59 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602072236.GV15686@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=eric.nelson@boundarydevices.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox