dev_param_int_ro

dev_param_int_ro

[Herve Codina]

Hi,

We can have parameters based on long long int.
For instance :
dev_add_param_int_ro(&mtd->class_dev, "size", mtd->size, "%llu");

This is not working because dev_add_param_int_ro expect int as value and
calling asprintf using "%llu" format and int parameter does not give
expected result.

We need to add a specific dev_add_param_int_ro function for long long.
What function name should be used ?
- dev_add_param_intll_ro
- dev_add_param_llint_ro
- dev_add_param_ll_ro

I can do this small patch according to choosen function name.

Best regards,
Herve



_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: dev_param_int_ro

[Sascha Hauer]

On Wed, Jun 11, 2014 at 01:34:43PM +0200, Herve Codina wrote:
> Hi,
> 
> We can have parameters based on long long int.
> For instance :
> dev_add_param_int_ro(&mtd->class_dev, "size", mtd->size, "%llu");
> 
> This is not working because dev_add_param_int_ro expect int as value and
> calling asprintf using "%llu" format and int parameter does not give
> expected result.
> 
> We need to add a specific dev_add_param_int_ro function for long long.
> What function name should be used ?
> - dev_add_param_intll_ro
> - dev_add_param_llint_ro
> - dev_add_param_ll_ro
> 
> I can do this small patch according to choosen function name.

So many options ;)

dev_add_param_llint_ro sounds best to me.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox