mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Herve Codina <Herve.CODINA@celad.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] param: Add support for long long read only dev param
Date: Fri, 13 Jun 2014 06:27:52 +0200	[thread overview]
Message-ID: <20140613042752.GD15686@pengutronix.de> (raw)
In-Reply-To: <1402565858-7098-1-git-send-email-Herve.CODINA@celad.com>

On Thu, Jun 12, 2014 at 11:37:37AM +0200, Herve Codina wrote:
> Signed-off-by: Herve Codina <Herve.CODINA@celad.com>

Applied both, thanks

Sascha

> ---
>  include/param.h |    9 +++++++++
>  lib/parameter.c |   26 ++++++++++++++++++++++++++
>  2 files changed, 35 insertions(+)
> 
> diff --git a/include/param.h b/include/param.h
> index eac3372..24827c5 100644
> --- a/include/param.h
> +++ b/include/param.h
> @@ -49,6 +49,9 @@ struct param_d *dev_add_param_enum(struct device_d *dev, const char *name,
>  struct param_d *dev_add_param_int_ro(struct device_d *dev, const char *name,
>  		int value, const char *format);
>  
> +struct param_d *dev_add_param_llint_ro(struct device_d *dev, const char *name,
> +		long long value, const char *format);
> +
>  struct param_d *dev_add_param_ip(struct device_d *dev, const char *name,
>  		int (*set)(struct param_d *p, void *priv),
>  		int (*get)(struct param_d *p, void *priv),
> @@ -123,6 +126,12 @@ static inline struct param_d *dev_add_param_int_ro(struct device_d *dev, const c
>  	return NULL;
>  }
>  
> +static inline struct param_d *dev_add_param_llint_ro(struct device_d *dev, const char *name,
> +		long long value, const char *format)
> +{
> +	return NULL;
> +}
> +
>  static inline struct param_d *dev_add_param_ip(struct device_d *dev, const char *name,
>  		int (*set)(struct param_d *p, void *priv),
>  		int (*get)(struct param_d *p, void *priv),
> diff --git a/lib/parameter.c b/lib/parameter.c
> index b1f9aa3..13062bc 100644
> --- a/lib/parameter.c
> +++ b/lib/parameter.c
> @@ -468,6 +468,32 @@ struct param_d *dev_add_param_int_ro(struct device_d *dev, const char *name,
>  	return &piro->param;
>  }
>  
> +/**
> + * dev_add_param_llint_ro - add a read only long long parameter to a device
> + * @param dev	The device
> + * @param name	The name of the parameter
> + * @param value	The value of the parameter
> + * @param format the printf format used to print the value
> + */
> +struct param_d *dev_add_param_llint_ro(struct device_d *dev, const char *name,
> +		long long value, const char *format)
> +{
> +	struct param_int *piro;
> +	int ret;
> +
> +	piro = xzalloc(sizeof(*piro));
> +
> +	ret = __dev_add_param(&piro->param, dev, name, NULL, NULL, 0);
> +	if (ret) {
> +		free(piro);
> +		return ERR_PTR(ret);
> +	}
> +
> +	piro->param.value = asprintf(format, value);
> +
> +	return &piro->param;
> +}
> +
>  #ifdef CONFIG_NET
>  struct param_ip {
>  	struct param_d param;
> -- 
> 1.7.9.5
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      parent reply	other threads:[~2014-06-13  4:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-12  9:37 Herve Codina
2014-06-12  9:37 ` [PATCH 2/2] mtd: use long long dev param for size Herve Codina
2014-06-13  4:27 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140613042752.GD15686@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=Herve.CODINA@celad.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox