From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC v2 2/2] [WIP] net: add initial ENC28J60 support
Date: Mon, 23 Jun 2014 08:33:49 +0200 [thread overview]
Message-ID: <20140623063349.GN15686@pengutronix.de> (raw)
In-Reply-To: <1402904480-6765-2-git-send-email-antonynpavlov@gmail.com>
On Mon, Jun 16, 2014 at 11:41:20AM +0400, Antony Pavlov wrote:
> ENC28J60 is a stand-alone Ethernet controller with SPI Interface.
> and integrated 10BASE-T PHY.
>
> This driver was ported from linux-3.15.
>
> The most notable barebox driver version changes:
> * add device tree support;
> * use IF_ENABLED for checking CONFIG_ENC28J60_WRITEVERIFY;
> * add mii_bus support;
> * rename {nolock,locked}_regw_{read,write}() to enc28j60_*_{read,write}().
>
> TODOs:
> * receive only one packet per enc28j60_eth_rx() call.
> * fix empty enc28j60_init_dev;
> * add parameter for changing debug loglevel on-the-run;
> * ENC28J60 supports only SPI mode 0 so we have to submit
> this information to the SPI controller explicitly.
>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
>
> Changes since v1:
> * drop unused macros;
> * use random_ether_addr();
> * drop 'select CRC32' in Kconfig;
> * drop MAC address generation in driver's code;
> * rename {nolock,locked}_regw_{read,write}() to enc28j60_*_{read,write}();
> * add mii_bus support.
>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
...
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> new file mode 100644
> index 0000000..4884854
I don't really like the headerfile leaking in from Linux just to make
this driver compile. Also I think such a fine grained network device
debugging is not so useful for barebox. So can you drop this? Otherwise
I'm fine with the driver.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-06-23 6:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 7:41 [RFC v2 1/2] [WIP] net.h: add ETH_ALEN constant; fix whitespaces Antony Pavlov
2014-06-16 7:41 ` [RFC v2 2/2] [WIP] net: add initial ENC28J60 support Antony Pavlov
2014-06-23 6:33 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140623063349.GN15686@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox