mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Holger Schurig <holgerschurig@gmail.com>
Cc: "barebox@lists.infradead.org" <barebox@lists.infradead.org>
Subject: Re: SFI NOR sizes totally off ?!?
Date: Mon, 23 Jun 2014 11:59:32 +0200	[thread overview]
Message-ID: <20140623095931.GW15686@pengutronix.de> (raw)
In-Reply-To: <CAOpc7mF_bAvNVebmS7F2ow4fj6peFgjxyY=1F-NQyvfb88XqHg@mail.gmail.com>

On Mon, Jun 23, 2014 at 11:28:09AM +0200, Holger Schurig wrote:
> Seems like "ls -l" is right, but "devinfo" is wrong:
> 
> barebox:/ ls -l /dev/m25p0
> crw-------   67108864 /dev/m25p0
> barebox:/ devinfo m25p0
> Parameters:
>   size: 5468012149590870304
>   erasesize: 4096
>   writesize: 1
>   oobsize: 0

This should be fixed with the following Commit.

Grumpf. We really need some stable strategy.

Sascha

commit 3ee907d89eaeaee5f75bd73eb89d2b4b3d05f6d4
Author: Herve Codina <Herve.CODINA@celad.com>
Date:   Thu Jun 12 11:37:38 2014 +0200

    mtd: use long long dev param for size
    
    Signed-off-by: Herve Codina <Herve.CODINA@celad.com>
    Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

diff --git a/drivers/mtd/core.c b/drivers/mtd/core.c
index d3e7763..82fb5f7 100644
--- a/drivers/mtd/core.c
+++ b/drivers/mtd/core.c
@@ -401,7 +401,7 @@ int add_mtd_device(struct mtd_info *mtd, char *devname, int device_id)
        mtd->cdev.mtd = mtd;
 
        if (IS_ENABLED(CONFIG_PARAMETER)) {
-               dev_add_param_int_ro(&mtd->class_dev, "size", mtd->size, "%llu");
+               dev_add_param_llint_ro(&mtd->class_dev, "size", mtd->size, "%llu");
                dev_add_param_int_ro(&mtd->class_dev, "erasesize", mtd->erasesize, "%u");
                dev_add_param_int_ro(&mtd->class_dev, "writesize", mtd->writesize, "%u");
                dev_add_param_int_ro(&mtd->class_dev, "oobsize", mtd->oobsize, "%u");


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2014-06-23 10:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-23  9:28 Holger Schurig
2014-06-23  9:59 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140623095931.GW15686@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=holgerschurig@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox