From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: "U-Boot Version 2 (barebox)" <barebox@lists.infradead.org>
Subject: Re: a couple consistent misspellings that could be fixed
Date: Thu, 26 Jun 2014 21:09:37 +0200 [thread overview]
Message-ID: <20140626190937.GF14257@pengutronix.de> (raw)
In-Reply-To: <alpine.LFD.2.11.1406261425060.31619@localhost>
On Thu, Jun 26, 2014 at 02:28:21PM -0400, Robert P. J. Day wrote:
>
> being the pedant that i am, i notice the following widespread
> misspellings in the barebox codebase:
>
> * "existance" (should be existence)
>
> actually, not that widespread, only three, all comments so easy to
> fix
>
> * "persistant" (should be persistent)
>
> this one is much uglier -- a couple dozen, including its use in
> runnable code itself. just run:
>
> $ grep -r persistant *
Uh, quite a few.
>
> to see what i mean.
>
> what's the policy for fixing a spelling error that spills over from
> the comments into compilable code itself?
You can fix them all in a single patch, no need to split it up. At least
not as long there's not a function which uses 'persistent' and
'persistant' as two different variables ;)
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-06-26 19:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-26 18:28 Robert P. J. Day
2014-06-26 19:09 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140626190937.GF14257@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox