mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] imx6:phyFLEX: Fix ENTRY_FUNCTION
@ 2014-06-26 14:09 Christian Hemp
  2014-06-26 14:29 ` Alexander Aring
  2014-06-26 19:38 ` Sascha Hauer
  0 siblings, 2 replies; 3+ messages in thread
From: Christian Hemp @ 2014-06-26 14:09 UTC (permalink / raw)
  To: barebox; +Cc: Christian Hemp

For some phyFLEX-i.MX6 modules the call __barebox_arm_head() was not removed.
With this function the barebox does not start.

Signed-off-by: Christian Hemp <christian.hemp@gmail.com>
---
 arch/arm/boards/phytec-phyflex-imx6/lowlevel.c |    6 ------
 1 file changed, 6 deletions(-)

diff --git a/arch/arm/boards/phytec-phyflex-imx6/lowlevel.c b/arch/arm/boards/phytec-phyflex-imx6/lowlevel.c
index 6c6f660..4350adb 100644
--- a/arch/arm/boards/phytec-phyflex-imx6/lowlevel.c
+++ b/arch/arm/boards/phytec-phyflex-imx6/lowlevel.c
@@ -93,8 +93,6 @@ ENTRY_FUNCTION(start_phytec_pbab01_4gib, r0, r1, r2)
 {
 	void *fdt;
 
-	__barebox_arm_head();
-
 	arm_cpu_lowlevel_init();
 
 	arm_setup_stack(0x00920000 - 8);
@@ -108,8 +106,6 @@ ENTRY_FUNCTION(start_phytec_pbab01dl_1gib, r0, r1, r2)
 {
 	void *fdt;
 
-        __barebox_arm_head();
-
         arm_cpu_lowlevel_init();
 
         arm_setup_stack(0x00920000 - 8);
@@ -123,8 +119,6 @@ ENTRY_FUNCTION(start_phytec_pbab01s_512mb, r0, r1, r2)
 {
 	void *fdt;
 
-	__barebox_arm_head();
-
 	arm_cpu_lowlevel_init();
 
 	arm_setup_stack(0x00920000 - 8);
-- 
1.7.9.5


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] imx6:phyFLEX: Fix ENTRY_FUNCTION
  2014-06-26 14:09 [PATCH] imx6:phyFLEX: Fix ENTRY_FUNCTION Christian Hemp
@ 2014-06-26 14:29 ` Alexander Aring
  2014-06-26 19:38 ` Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Alexander Aring @ 2014-06-26 14:29 UTC (permalink / raw)
  To: Christian Hemp; +Cc: barebox

Hi,

On Thu, Jun 26, 2014 at 04:09:17PM +0200, Christian Hemp wrote:
> For some phyFLEX-i.MX6 modules the call __barebox_arm_head() was not removed.
> With this function the barebox does not start.
> 
> Signed-off-by: Christian Hemp <christian.hemp@gmail.com>
> ---
>  arch/arm/boards/phytec-phyflex-imx6/lowlevel.c |    6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/arch/arm/boards/phytec-phyflex-imx6/lowlevel.c b/arch/arm/boards/phytec-phyflex-imx6/lowlevel.c
> index 6c6f660..4350adb 100644
> --- a/arch/arm/boards/phytec-phyflex-imx6/lowlevel.c
> +++ b/arch/arm/boards/phytec-phyflex-imx6/lowlevel.c
> @@ -93,8 +93,6 @@ ENTRY_FUNCTION(start_phytec_pbab01_4gib, r0, r1, r2)
>  {
>  	void *fdt;
>  
> -	__barebox_arm_head();
> -
>  	arm_cpu_lowlevel_init();
>  
>  	arm_setup_stack(0x00920000 - 8);
> @@ -108,8 +106,6 @@ ENTRY_FUNCTION(start_phytec_pbab01dl_1gib, r0, r1, r2)
>  {
>  	void *fdt;
>  
> -        __barebox_arm_head();
> -
>          arm_cpu_lowlevel_init();
>  
>          arm_setup_stack(0x00920000 - 8);


In this function is also some spaces instead tabs.

- Alex

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] imx6:phyFLEX: Fix ENTRY_FUNCTION
  2014-06-26 14:09 [PATCH] imx6:phyFLEX: Fix ENTRY_FUNCTION Christian Hemp
  2014-06-26 14:29 ` Alexander Aring
@ 2014-06-26 19:38 ` Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2014-06-26 19:38 UTC (permalink / raw)
  To: Christian Hemp; +Cc: barebox

On Thu, Jun 26, 2014 at 04:09:17PM +0200, Christian Hemp wrote:
> For some phyFLEX-i.MX6 modules the call __barebox_arm_head() was not removed.
> With this function the barebox does not start.
> 
> Signed-off-by: Christian Hemp <christian.hemp@gmail.com>

Applied, thanks (and fixed the whitespaces while applying)

Sascha

> ---
>  arch/arm/boards/phytec-phyflex-imx6/lowlevel.c |    6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/arch/arm/boards/phytec-phyflex-imx6/lowlevel.c b/arch/arm/boards/phytec-phyflex-imx6/lowlevel.c
> index 6c6f660..4350adb 100644
> --- a/arch/arm/boards/phytec-phyflex-imx6/lowlevel.c
> +++ b/arch/arm/boards/phytec-phyflex-imx6/lowlevel.c
> @@ -93,8 +93,6 @@ ENTRY_FUNCTION(start_phytec_pbab01_4gib, r0, r1, r2)
>  {
>  	void *fdt;
>  
> -	__barebox_arm_head();
> -
>  	arm_cpu_lowlevel_init();
>  
>  	arm_setup_stack(0x00920000 - 8);
> @@ -108,8 +106,6 @@ ENTRY_FUNCTION(start_phytec_pbab01dl_1gib, r0, r1, r2)
>  {
>  	void *fdt;
>  
> -        __barebox_arm_head();
> -
>          arm_cpu_lowlevel_init();
>  
>          arm_setup_stack(0x00920000 - 8);
> @@ -123,8 +119,6 @@ ENTRY_FUNCTION(start_phytec_pbab01s_512mb, r0, r1, r2)
>  {
>  	void *fdt;
>  
> -	__barebox_arm_head();
> -
>  	arm_cpu_lowlevel_init();
>  
>  	arm_setup_stack(0x00920000 - 8);
> -- 
> 1.7.9.5
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-06-26 19:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-26 14:09 [PATCH] imx6:phyFLEX: Fix ENTRY_FUNCTION Christian Hemp
2014-06-26 14:29 ` Alexander Aring
2014-06-26 19:38 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox