[PATCH] kconfig: Fix compiler warning

[PATCH] kconfig: Fix compiler warning

[Sascha Hauer]

gcc-4.9 is too silly to recognize that *jump cannot be used
uninitialized and issues a warning. Explicitly initialize
*jump to avoid the warning.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 scripts/kconfig/menu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index fd3f018..bea100b 100644
--- a/scripts/kconfig/menu.c
+++ b/scripts/kconfig/menu.c
@@ -525,7 +525,7 @@ static void get_prompt_str(struct gstr *r, struct property *prop,
 {
 	int i, j;
 	struct menu *submenu[8], *menu, *location = NULL;
-	struct jump_key *jump;
+	struct jump_key *jump = NULL;
 
 	str_printf(r, _("Prompt: %s\n"), _(prop->text));
 	menu = prop->menu->parent;
-- 
2.0.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] kconfig: Fix compiler warning

[Alexander Aring]

Hi Sascha,

I get this warning about 1 month and it makes me crazy and I am unsing
"gcc (GCC) 4.9.0 20140604 (prerelease)".


Why I didn't sent any patches?
Because you say it here it's a compiler bug and the linux world doesn't
fix it this way. Look at [0].

"... since we will still want to catch unitialised use in the future,
should we were to changethe code." - which sounds useful.

They already add a comment to this. I think otherwise they get much
patches because this warning.

When I look into the current mainline code [1]. Then this is currently
not fixed in any way (comment or setting to NULL

- Alex

[0] http://www.spinics.net/lists/linux-kbuild/msg08898.html
[1] https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/scripts/kconfig/menu.c?id=refs/tags/next-20140626

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] kconfig: Fix compiler warning

[Uwe Kleine-König]

On Thu, Jun 26, 2014 at 11:02:18AM +0200, Alexander Aring wrote:
> Hi Sascha,
> 
> I get this warning about 1 month and it makes me crazy and I am unsing
> "gcc (GCC) 4.9.0 20140604 (prerelease)".
> 
> 
> Why I didn't sent any patches?
> Because you say it here it's a compiler bug and the linux world doesn't
> fix it this way. Look at [0].
> 
> "... since we will still want to catch unitialised use in the future,
> should we were to changethe code." - which sounds useful.
> 
> They already add a comment to this. I think otherwise they get much
> patches because this warning.
> 
> When I look into the current mainline code [1]. Then this is currently
> not fixed in any way (comment or setting to NULL
There is also the macro uninitialized_var (in both kernel and barebox)
that could be used here instead of the explicit = NULL.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox