[PATCH v2] menutree: let it select GLOB and GLOB_SORT

[PATCH v2] menutree: let it select GLOB and GLOB_SORT

[Holger Schurig]

The menutree doesn't select CONFIG_GLOB, but it depends on it. Without
it will just hang. So let it select it automatically. Also remove the
dependency of CONFIG_GLOB on CONFIG_HUSH, because glob() will run with
the simple shell as well.

Also let CONFIG_MENUTREE select on CONFIG_GLOB_SORT. While is not
strictly needed, many people use menu/00-foo menu/10-bar menu/20-barf
to sort their menu entries. So select it out of convenience.

Signed-off-by: Holger Schurig <holgerschurig@gmail.com>
---

v2: just changed the commit text

 common/Kconfig |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/common/Kconfig b/common/Kconfig
index 1afee93..bba7f15 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -61,6 +61,8 @@ config BAREBOX_UPDATE
 
 config MENUTREE
 	bool
+	select GLOB
+	select GLOB_SORT
 
 menu "General Settings"
 
@@ -338,11 +340,13 @@ config MAXARGS
 
 config GLOB
 	bool
-	prompt "hush globbing support"
-	depends on SHELL_HUSH
+	prompt "globbing support"
 	help
 	  If you want to use wildcards like * or ? say y here.
 
+	  Globbing can be used in the HUSH shell, but is also used
+	  internally in the menutree command.
+
 config GLOB_SORT
 	select QSORT
 	bool
-- 
1.7.10.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH v2] menutree: let it select GLOB and GLOB_SORT

[Sascha Hauer]

On Tue, Jul 01, 2014 at 10:08:06AM +0200, Holger Schurig wrote:
> The menutree doesn't select CONFIG_GLOB, but it depends on it. Without
> it will just hang. So let it select it automatically. Also remove the
> dependency of CONFIG_GLOB on CONFIG_HUSH, because glob() will run with
> the simple shell as well.
> 
> Also let CONFIG_MENUTREE select on CONFIG_GLOB_SORT. While is not
> strictly needed, many people use menu/00-foo menu/10-bar menu/20-barf
> to sort their menu entries. So select it out of convenience.
> 
> Signed-off-by: Holger Schurig <holgerschurig@gmail.com>

Took this one instead.

Sascha

> ---
> 
> v2: just changed the commit text
> 
>  common/Kconfig |    8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/common/Kconfig b/common/Kconfig
> index 1afee93..bba7f15 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -61,6 +61,8 @@ config BAREBOX_UPDATE
>  
>  config MENUTREE
>  	bool
> +	select GLOB
> +	select GLOB_SORT
>  
>  menu "General Settings"
>  
> @@ -338,11 +340,13 @@ config MAXARGS
>  
>  config GLOB
>  	bool
> -	prompt "hush globbing support"
> -	depends on SHELL_HUSH
> +	prompt "globbing support"
>  	help
>  	  If you want to use wildcards like * or ? say y here.
>  
> +	  Globbing can be used in the HUSH shell, but is also used
> +	  internally in the menutree command.
> +
>  config GLOB_SORT
>  	select QSORT
>  	bool
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox