From: Sascha Hauer <s.hauer@pengutronix.de>
To: Rolf Evers-Fischer <embedded24@evers-fischer.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] boot: show all boot sources
Date: Wed, 2 Jul 2014 08:30:00 +0200 [thread overview]
Message-ID: <20140702063000.GB14257@pengutronix.de> (raw)
In-Reply-To: <alpine.DEB.2.10.1407011407550.7233@9VTHT2J-D520>
On Tue, Jul 01, 2014 at 02:10:07PM +0200, Rolf Evers-Fischer wrote:
>
>
> On Tue, 1 Jul 2014, Sascha Hauer wrote:
>
> >What exactly fixes this? Looking at the code we have:
> >
> > if (optind < argc) {
> > num_sources = argc - optind;
> > sources = xmemdup(&argv[optind], sizeof(char *) *num_sources);
> > } else {
> > ...
> > }
> >
> >Which should do what you want.
>
> Unfortunately it doesn't do what I want. If I invoke "boot -l" on the bb
> shell, I get optind=argc=2. Therefore barebox executes the "else" clause,
> which lists only the default bootsource.
Right, but what else should the command list if you do not give
additional arguments?
I mean the intention is that
boot -l <source1> <source2>
lists all sources specified, whereas
boot -l
lists everything from $global.boot.default
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-07-02 6:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 12:21 Rolf Evers-Fischer
2014-07-01 6:54 ` Sascha Hauer
2014-07-01 12:10 ` Rolf Evers-Fischer
2014-07-02 6:30 ` Sascha Hauer [this message]
2014-07-02 10:01 ` Rolf Evers-Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140702063000.GB14257@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=embedded24@evers-fischer.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox