From: Sascha Hauer <s.hauer@pengutronix.de>
To: Herve Codina <Herve.CODINA@celad.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/1] hush: Fix error code returned value
Date: Tue, 8 Jul 2014 07:45:22 +0200 [thread overview]
Message-ID: <20140708054522.GR23235@pengutronix.de> (raw)
In-Reply-To: <1404722708-4623-1-git-send-email-Herve.CODINA@celad.com>
On Mon, Jul 07, 2014 at 10:45:08AM +0200, Herve Codina wrote:
> Just returns error code instead of 0 or 1.
>
> With this fix, $? is set to child exit code in all cases.
> Without this fix, /child $PATH;echo $? displays 1 even if
> child script calls exit with a specific non zero error code.
>
> Signed-off-by: Herve Codina <Herve.CODINA@celad.com>
Applied, thanks
Sascha
> ---
> common/hush.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/hush.c b/common/hush.c
> index 6be43cf..f6aaa03 100644
> --- a/common/hush.c
> +++ b/common/hush.c
> @@ -1724,7 +1724,7 @@ static int parse_stream_outer(struct p_context *ctx, struct in_str *inp, int fla
> b_free(&temp);
> } while (rcode != -1 && !(flag & FLAG_EXIT_FROM_LOOP)); /* loop on syntax errors, return on EOF */
>
> - return (code != 0) ? 1 : 0;
> + return code;
> }
>
> static int parse_string_outer(struct p_context *ctx, const char *s, int flag)
> --
> 1.7.9.5
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-07-08 5:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 8:45 Herve Codina
2014-07-08 5:45 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140708054522.GR23235@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=Herve.CODINA@celad.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox