[PATCH] pci: pci_alloc_bus(): use xzalloc() instead of kzalloc()

[PATCH] pci: pci_alloc_bus(): use xzalloc() instead of kzalloc()

[Antony Pavlov]

Also drop redundant xzalloc() result check
as xzalloc() does not return in case of memory allocation error.

Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
 drivers/pci/pci.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index ad9350f..3d88b0f 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -16,14 +16,14 @@ static struct pci_bus *pci_alloc_bus(void)
 {
 	struct pci_bus *b;
 
-	b = kzalloc(sizeof(*b), GFP_KERNEL);
-	if (b) {
-		INIT_LIST_HEAD(&b->node);
-		INIT_LIST_HEAD(&b->children);
-		INIT_LIST_HEAD(&b->devices);
-		INIT_LIST_HEAD(&b->slots);
-		INIT_LIST_HEAD(&b->resources);
-	}
+	b = xzalloc(sizeof(*b));
+
+	INIT_LIST_HEAD(&b->node);
+	INIT_LIST_HEAD(&b->children);
+	INIT_LIST_HEAD(&b->devices);
+	INIT_LIST_HEAD(&b->slots);
+	INIT_LIST_HEAD(&b->resources);
+
 	return b;
 }
 
-- 
2.0.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] pci: pci_alloc_bus(): use xzalloc() instead of kzalloc()

[Sascha Hauer]

On Wed, Jul 09, 2014 at 12:23:11AM +0400, Antony Pavlov wrote:
> Also drop redundant xzalloc() result check
> as xzalloc() does not return in case of memory allocation error.
> 
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>

Applied, thanks

Sascha

> ---
>  drivers/pci/pci.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index ad9350f..3d88b0f 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -16,14 +16,14 @@ static struct pci_bus *pci_alloc_bus(void)
>  {
>  	struct pci_bus *b;
>  
> -	b = kzalloc(sizeof(*b), GFP_KERNEL);
> -	if (b) {
> -		INIT_LIST_HEAD(&b->node);
> -		INIT_LIST_HEAD(&b->children);
> -		INIT_LIST_HEAD(&b->devices);
> -		INIT_LIST_HEAD(&b->slots);
> -		INIT_LIST_HEAD(&b->resources);
> -	}
> +	b = xzalloc(sizeof(*b));
> +
> +	INIT_LIST_HEAD(&b->node);
> +	INIT_LIST_HEAD(&b->children);
> +	INIT_LIST_HEAD(&b->devices);
> +	INIT_LIST_HEAD(&b->slots);
> +	INIT_LIST_HEAD(&b->resources);
> +
>  	return b;
>  }
>  
> -- 
> 2.0.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox