mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Rolf Evers-Fischer <embedded24@evers-fischer.de>
Cc: barebox@lists.infradead.org
Subject: Re: AM335x MLO images broken
Date: Thu, 10 Jul 2014 23:28:36 +0200	[thread overview]
Message-ID: <20140710212836.GF23235@pengutronix.de> (raw)
In-Reply-To: <alpine.DEB.2.10.1407100925060.3269@9VTHT2J-D520>

On Thu, Jul 10, 2014 at 09:37:37AM +0200, Rolf Evers-Fischer wrote:
> Hello Sascha,
> 
> Sascha Hauer <s.hauer@...> writes:
> 
> > Looks like a side effect of:
> > 
> > | commit d1ec6fb0c9bb66939e85964c2f5214b117c78ecf
> > | Author: Sascha Hauer <s.hauer@...>
> > | Date:   Mon Jul 7 14:13:14 2014 +0200
> > | 
> > |     ARM: OMAP: Do not show MLO/SPI image options with OMAP_MULTI_BOARDS
> > |     
> > |     The MLO/SPI image options have no effect with OMAP_MULTI_BOARDS
> > |     enabled, so do not show them.
> > |     
> > |     Signed-off-by: Sascha Hauer <s.hauer@...>
> > 
> > I haven't looked whether there's a better solution than reverting the
> > commit.
> > 
> 
> your patch disables generation of MLO/SPI image, if OMAP_MULTI_BOARDS is 
> enabled. But shouldn't it be vice versa? I mean, both boards 
> (MACH_BEAGLEBONE and MACH_PCM051), which are dependend on 
> OMAP_MULTI_BOARDS, need a working MLO image. From my point of view it 
> makes sense to ENable the OMAP_BUILD_IFT along with OMAP_MULTI_BOARDS.

Indeed. I'll just revert the patch.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2014-07-10 21:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-10  7:37 Rolf Evers-Fischer
2014-07-10 21:28 ` Sascha Hauer [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-07-09 15:50 Teresa Gamez
2014-07-09 16:47 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140710212836.GF23235@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=embedded24@evers-fischer.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox