From: Antony Pavlov <antonynpavlov@gmail.com>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2] i2c: add Marvell 64xxx driver
Date: Tue, 22 Jul 2014 15:58:22 +0400 [thread overview]
Message-ID: <20140722155822.3a49058937190951d1873f34@gmail.com> (raw)
In-Reply-To: <53CE4594.7020601@gmail.com>
On Tue, 22 Jul 2014 13:05:56 +0200
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> wrote:
> On 07/22/2014 11:57 AM, Antony Pavlov wrote:
> > On Tue, 22 Jul 2014 10:51:10 +0200
> > Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> wrote:
> >> On 07/16/2014 11:25 PM, Antony Pavlov wrote:
> >>> This driver is also used for Allwinner SoCs I2C controllers.
> >>>
> >>> Ported from linux-3.15.
> >>>
> >>> The most notable barebox driver version changes:
> >>>
> >>> * drop message offloading support;
> >>> * add reg-io-width parameter to use driver with byte-oriented
> >>> controller versions.
> >>>
> >>> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> >>
> >> Antony,
> >>
> >> I finally finished work on xHCI and PCI on Armada 370. Now I come
> >> back with the promised review of the i2c driver.
> >>
> >> I gave this driver a quick test on Mirabox, i2c_probe just gives I2C bus
> >> errors. What SoC did you test the driver on?
> >
> > I test it on custom FPGA-based byte-oriented mv64xxx-style i2c controller.
> >
> > Linux 3.15 driver succesfully works with my controller. The only change is adding
> > mv64xxx_write/mv64xxx_read functions for enabling byte registers access.
> >
> > Have you probed your Mirabox i2c bus under linux?
>
> Actually, I switched to Dove CuBox after I realized that Mirabox has
> nothing on i2c on-board but only externally connected ;)
>
> Now you can add my
>
> Tested-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Very good!
I'll send PATCH v3 in several days.
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-07-22 11:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 21:25 Antony Pavlov
2014-07-16 21:25 ` Antony Pavlov
2014-07-17 9:33 ` Sebastian Hesselbarth
2014-07-17 11:59 ` Antony Pavlov
2014-07-22 8:51 ` Sebastian Hesselbarth
2014-07-22 9:57 ` Antony Pavlov
2014-07-22 11:05 ` Sebastian Hesselbarth
2014-07-22 11:58 ` Antony Pavlov [this message]
2014-07-22 16:21 ` Antony Pavlov
2014-07-22 16:53 ` Sebastian Hesselbarth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140722155822.3a49058937190951d1873f34@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox