From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC] usb: ehci: use linux-way ehci_readl and ehci_writel
Date: Wed, 23 Jul 2014 09:14:08 +0200 [thread overview]
Message-ID: <20140723071408.GF23235@pengutronix.de> (raw)
In-Reply-To: <1405598047-2607-1-git-send-email-antonynpavlov@gmail.com>
On Thu, Jul 17, 2014 at 03:54:07PM +0400, Antony Pavlov wrote:
> Also drop nowhere defined CONFIG_EHCI_DESC_BIG_ENDIAN.
>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
Applied, thanks
Sascha
> ---
> drivers/usb/host/ehci.h | 19 +++++++++++--------
> 1 file changed, 11 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
> index 5d899cc..2ec69f6 100644
> --- a/drivers/usb/host/ehci.h
> +++ b/drivers/usb/host/ehci.h
> @@ -18,6 +18,8 @@
> #ifndef USB_EHCI_H
> #define USB_EHCI_H
>
> +#include <io.h>
> +
> #if !defined(CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS)
> #define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS 16
> #endif
> @@ -109,14 +111,15 @@ struct usb_linux_config_descriptor {
> unsigned char MaxPower;
> } __attribute__ ((packed));
>
> -#if defined CONFIG_EHCI_DESC_BIG_ENDIAN
> -#define ehci_readl(x) (*((volatile u32 *)(x)))
> -#define ehci_writel(a, b) (*((volatile u32 *)(a)) = ((volatile u32)b))
> -#else
> -#define ehci_readl(x) cpu_to_le32((*((volatile u32 *)(x))))
> -#define ehci_writel(a, b) (*((volatile u32 *)(a)) = \
> - cpu_to_le32(((volatile u32)b)))
> -#endif
> +static inline void ehci_writel(const unsigned int val, __u32 __iomem *regs)
> +{
> + writel(val, regs);
> +}
> +
> +static inline unsigned int ehci_readl(__u32 __iomem *regs)
> +{
> + return readl(regs);
> +}
>
> #if defined CONFIG_EHCI_MMIO_BIG_ENDIAN
> #define hc32_to_cpu(x) be32_to_cpu((x))
> --
> 2.0.1
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-07-23 7:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 11:54 Antony Pavlov
2014-07-23 7:14 ` Sascha Hauer [this message]
2014-07-24 7:03 ` Sascha Hauer
2014-07-24 7:43 ` Antony Pavlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140723071408.GF23235@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox