From: Antony Pavlov <antonynpavlov@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC] usb: ehci: use linux-way ehci_readl and ehci_writel
Date: Thu, 24 Jul 2014 11:43:11 +0400 [thread overview]
Message-ID: <20140724114311.564666f934e3054594858b81@gmail.com> (raw)
In-Reply-To: <20140724070347.GG23282@pengutronix.de>
On Thu, 24 Jul 2014 09:03:47 +0200
Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Wed, Jul 23, 2014 at 09:14:08AM +0200, Sascha Hauer wrote:
> > On Thu, Jul 17, 2014 at 03:54:07PM +0400, Antony Pavlov wrote:
> > > Also drop nowhere defined CONFIG_EHCI_DESC_BIG_ENDIAN.
> > >
> > > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> >
> > Applied, thanks
>
> And reverted it.
>
> > > -#if defined CONFIG_EHCI_DESC_BIG_ENDIAN
> > > -#define ehci_readl(x) (*((volatile u32 *)(x)))
> > > -#define ehci_writel(a, b) (*((volatile u32 *)(a)) = ((volatile u32)b))
> > > -#else
> > > -#define ehci_readl(x) cpu_to_le32((*((volatile u32 *)(x))))
> > > -#define ehci_writel(a, b) (*((volatile u32 *)(a)) = \
> > > - cpu_to_le32(((volatile u32)b)))
> > > -#endif
> > > +static inline void ehci_writel(const unsigned int val, __u32 __iomem *regs)
> > > +{
> > > + writel(val, regs);
> > > +}
>
> ehci_writel has the argument order (reg, val), not (val, reg)
>
> Putting a 'writel' in a function name with this argument order wasn't
> the best idea...
Sorry!
I have made this patch while I was working on AR933x USB support (big-endian EHCI).
I suppose this patch was initial buggy version and I have forgot to ammend fixup.
--
Best regards,
Antony Pavlov
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-07-24 7:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 11:54 Antony Pavlov
2014-07-23 7:14 ` Sascha Hauer
2014-07-24 7:03 ` Sascha Hauer
2014-07-24 7:43 ` Antony Pavlov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140724114311.564666f934e3054594858b81@gmail.com \
--to=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox