mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/9] ARM: add very initial support for Canon DIGIC chips
Date: Mon, 28 Jul 2014 08:09:32 +0200	[thread overview]
Message-ID: <20140728060932.GW23235@pengutronix.de> (raw)
In-Reply-To: <1406454448-10645-3-git-send-email-antonynpavlov@gmail.com>

On Sun, Jul 27, 2014 at 01:47:21PM +0400, Antony Pavlov wrote:
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> +++ b/arch/arm/mach-digic/core.c
> @@ -0,0 +1,24 @@
> +/*
> + * Copyright (C) 2013 Antony Pavlov <antonynpavlov@gmail.com>
> + *
> + * This file is part of barebox.
> + * See file CREDITS for list of people who contributed to this project.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2
> + * as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + */
> +
> +#include <common.h>
> +
> +void __noreturn reset_cpu(unsigned long ignored)
> +{
> +	unreachable();
> +}
> +EXPORT_SYMBOL(reset_cpu);

You shouldn't use unreachable here. unreachable is to suppress control
flow warnings when a code path is not reachable. The code above is
indeed reachable. A plain printf("%s: not implemented\n", __func__);
while(1); should do.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2014-07-28  6:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-27  9:47 [PATCH 0/9] ARM: add support for Canon DIGIC chips and Canon PowerShot A1100 IS Antony Pavlov
2014-07-27  9:47 ` [PATCH 1/9] ARM: add ARM946E-S CPU type Antony Pavlov
2014-07-27  9:47 ` [PATCH 2/9] ARM: add very initial support for Canon DIGIC chips Antony Pavlov
2014-07-28  6:09   ` Sascha Hauer [this message]
2014-07-27  9:47 ` [PATCH 3/9] clocksource: add driver for Canon DIGIC timer Antony Pavlov
2014-07-27  9:47 ` [PATCH 4/9] serial: add driver for Canon DIGIC UART Antony Pavlov
2014-07-27  9:47 ` [PATCH 5/9] gpio: add driver for Canon DIGIC Antony Pavlov
2014-07-27  9:47 ` [PATCH 6/9] ARM: DIGIC: add Canon PowerShot A1100 IS support Antony Pavlov
2014-07-27  9:47 ` [PATCH 7/9] ARM: add Canon A1100 ROM image generation Antony Pavlov
2014-07-27  9:47 ` [PATCH 8/9] ARM: DIGIC: add canon-a1100_defconfig Antony Pavlov
2014-07-27  9:47 ` [PATCH 9/9] Documentation: add QEMU Canon A1100 barebox mini-howto Antony Pavlov
2014-07-28  6:16   ` Sascha Hauer
2014-07-28  7:00     ` Antony Pavlov
2014-07-28 11:48     ` Antony Pavlov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140728060932.GW23235@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox