mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] led: try to get LED's label from the 'label' property
Date: Mon, 28 Jul 2014 08:29:13 +0200	[thread overview]
Message-ID: <20140728062913.GY23235@pengutronix.de> (raw)
In-Reply-To: <20140728102243.4fa06426337415ec0cabc26c@gmail.com>

On Mon, Jul 28, 2014 at 10:22:43AM +0400, Antony Pavlov wrote:
> On Mon, 28 Jul 2014 07:49:17 +0200
> Sascha Hauer <s.hauer@pengutronix.de> wrote:
> 
> > On Sun, Jul 27, 2014 at 12:35:52PM +0400, Antony Pavlov wrote:
> > > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> > > ---
> > >  drivers/led/led-gpio.c | 4 +++-
> > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/led/led-gpio.c b/drivers/led/led-gpio.c
> > > index 7bb3b49..cddac08 100644
> > > --- a/drivers/led/led-gpio.c
> > > +++ b/drivers/led/led-gpio.c
> > > @@ -212,7 +212,9 @@ static int led_gpio_of_probe(struct device_d *dev)
> > >  			continue;
> > >  
> > >  		gled = xzalloc(sizeof(*gled));
> > > -		gled->led.name = xstrdup(child->name);
> > > +		gled->led.name = xstrdup(of_get_property(child, "label", NULL));
> > 
> > When the property doesn't exist you pass NULL to xstrdup. This will
> > crash.
> 
> My bad. I have seen barebox strdup() realization but missed xstrdup() realization.
> 
> Barebox' strdup() can handle NULL argument:
> 
> char * strdup(const char *s)
> {
>         char *new;
> 
>         if ((s == NULL) ||
>             ((new = malloc (strlen(s) + 1)) == NULL) ) {                         
>                 return NULL;                                                     
>         }
> 
>         strcpy (new, s);
>         return new;
> }
> 
> But xstrdup() can't do so:
> 
> char *xstrdup(const char *s)
> {
>         char *p = strdup(s);
> 
>         if (!p)
>                 panic("ERROR: out of memory\n");
>         return p;
> }               
> 
> Can I just change first xstrdup() to strdup() in my patch?

Why not add a NULL pointer check to xstrdup?

> 
> E.g.
> 
> -               gled->led.name = xstrdup(of_get_property(child, "label", NULL));
> +               gled->led.name = strdup(of_get_property(child, "label", NULL));
>                 if (!gled->led.name)
>                         gled->led.name = xstrdup(child->name);

I think this code will raise questions. When reading this code one could
easily ask why stdrup is used in the first place and xstrdup in the
second. A year ahead even we may not know the answer without thinking
about it ;)

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2014-07-28  6:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-27  8:35 Antony Pavlov
2014-07-28  5:49 ` Sascha Hauer
2014-07-28  6:22   ` Antony Pavlov
2014-07-28  6:29     ` Sascha Hauer [this message]
2014-07-28  7:02       ` Antony Pavlov
2014-07-28  6:34     ` Sebastian Hesselbarth
2014-07-29  5:49       ` Antony Pavlov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140728062913.GY23235@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox