* [PATCH] commands: saveenv: Fix comment about directories in help text
@ 2014-08-01 6:17 Sascha Hauer
2014-08-01 6:45 ` Alexander Aring
0 siblings, 1 reply; 3+ messages in thread
From: Sascha Hauer @ 2014-08-01 6:17 UTC (permalink / raw)
To: barebox
envfs indeed handles directories, at least since 2007:
| commit 913691eccd13c1509470eb8b059aa0beecc6d8d8
| Author: Sascha Hauer <s.hauer@pengutronix.de>
| Date: Tue Sep 25 12:58:52 2007 +0200
|
| add directory handling for environment
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
commands/saveenv.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/commands/saveenv.c b/commands/saveenv.c
index 31d6951..9da733e 100644
--- a/commands/saveenv.c
+++ b/commands/saveenv.c
@@ -60,8 +60,7 @@ BAREBOX_CMD_HELP_TEXT("Save the files in DIRECTORY to the persistent storage dev
BAREBOX_CMD_HELP_TEXT("")
BAREBOX_CMD_HELP_TEXT("ENVFS is usually a block in flash but can be any other file. If")
BAREBOX_CMD_HELP_TEXT("omitted, DIRECTORY defaults to /env and ENVFS defaults to")
-BAREBOX_CMD_HELP_TEXT("/dev/env0. Note that envfs can only handle files, directories are being")
-BAREBOX_CMD_HELP_TEXT("skipped silently.")
+BAREBOX_CMD_HELP_TEXT("/dev/env0.")
BAREBOX_CMD_HELP_OPT ("-z", "force the built-in default environment at startup")
BAREBOX_CMD_HELP_END
--
2.0.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] commands: saveenv: Fix comment about directories in help text
2014-08-01 6:17 [PATCH] commands: saveenv: Fix comment about directories in help text Sascha Hauer
@ 2014-08-01 6:45 ` Alexander Aring
2014-09-01 10:51 ` Sascha Hauer
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Aring @ 2014-08-01 6:45 UTC (permalink / raw)
To: Sascha Hauer; +Cc: barebox
Hi Sascha,
On Fri, Aug 01, 2014 at 08:17:10AM +0200, Sascha Hauer wrote:
> envfs indeed handles directories, at least since 2007:
>
> | commit 913691eccd13c1509470eb8b059aa0beecc6d8d8
> | Author: Sascha Hauer <s.hauer@pengutronix.de>
> | Date: Tue Sep 25 12:58:52 2007 +0200
> |
> | add directory handling for environment
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> commands/saveenv.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/commands/saveenv.c b/commands/saveenv.c
> index 31d6951..9da733e 100644
> --- a/commands/saveenv.c
> +++ b/commands/saveenv.c
> @@ -60,8 +60,7 @@ BAREBOX_CMD_HELP_TEXT("Save the files in DIRECTORY to the persistent storage dev
> BAREBOX_CMD_HELP_TEXT("")
> BAREBOX_CMD_HELP_TEXT("ENVFS is usually a block in flash but can be any other file. If")
> BAREBOX_CMD_HELP_TEXT("omitted, DIRECTORY defaults to /env and ENVFS defaults to")
> -BAREBOX_CMD_HELP_TEXT("/dev/env0. Note that envfs can only handle files, directories are being")
> -BAREBOX_CMD_HELP_TEXT("skipped silently.")
> +BAREBOX_CMD_HELP_TEXT("/dev/env0.")
but envfs can't handle directories which are empty while saving? :-)
Maybe we should add this as note or support empty directories.
- Alex
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] commands: saveenv: Fix comment about directories in help text
2014-08-01 6:45 ` Alexander Aring
@ 2014-09-01 10:51 ` Sascha Hauer
0 siblings, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2014-09-01 10:51 UTC (permalink / raw)
To: Alexander Aring; +Cc: barebox
On Fri, Aug 01, 2014 at 08:45:04AM +0200, Alexander Aring wrote:
> Hi Sascha,
>
> On Fri, Aug 01, 2014 at 08:17:10AM +0200, Sascha Hauer wrote:
> > envfs indeed handles directories, at least since 2007:
> >
> > | commit 913691eccd13c1509470eb8b059aa0beecc6d8d8
> > | Author: Sascha Hauer <s.hauer@pengutronix.de>
> > | Date: Tue Sep 25 12:58:52 2007 +0200
> > |
> > | add directory handling for environment
> >
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > ---
> > commands/saveenv.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/commands/saveenv.c b/commands/saveenv.c
> > index 31d6951..9da733e 100644
> > --- a/commands/saveenv.c
> > +++ b/commands/saveenv.c
> > @@ -60,8 +60,7 @@ BAREBOX_CMD_HELP_TEXT("Save the files in DIRECTORY to the persistent storage dev
> > BAREBOX_CMD_HELP_TEXT("")
> > BAREBOX_CMD_HELP_TEXT("ENVFS is usually a block in flash but can be any other file. If")
> > BAREBOX_CMD_HELP_TEXT("omitted, DIRECTORY defaults to /env and ENVFS defaults to")
> > -BAREBOX_CMD_HELP_TEXT("/dev/env0. Note that envfs can only handle files, directories are being")
> > -BAREBOX_CMD_HELP_TEXT("skipped silently.")
> > +BAREBOX_CMD_HELP_TEXT("/dev/env0.")
>
> but envfs can't handle directories which are empty while saving? :-)
> Maybe we should add this as note or support empty directories.
I think we should add some more general docs how the environment works.
That would be a more appropriate place to add this note. Otherwise we
would have to add it to loadenv aswell.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-01 10:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-01 6:17 [PATCH] commands: saveenv: Fix comment about directories in help text Sascha Hauer
2014-08-01 6:45 ` Alexander Aring
2014-09-01 10:51 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox