From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Raphaël Poggi" <poggi.raph@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] pinctrl: at91: add pinctrl driver
Date: Mon, 4 Aug 2014 20:22:45 +0200 [thread overview]
Message-ID: <20140804182245.GE23235@pengutronix.de> (raw)
In-Reply-To: <1406899464-29144-2-git-send-email-poggi.raph@gmail.com>
Looks mostly fine.
On Fri, Aug 01, 2014 at 03:24:23PM +0200, Raphaël Poggi wrote:
> This driver is based on mach-at91/gpio.c and linux pinctrl driver.
> The driver contains the gpio and pinctrl parts (like in linux) because the two parts
> share some structures and logics.
>
> Signed-off-by: Raphaël Poggi <poggi.raph@gmail.com>
> ---
> +static struct at91_pinctrl_mux_ops *at91_pinctrl_get_driver_data(struct device_d *dev)
> +{
> + struct at91_pinctrl_mux_ops *ops_data = NULL;
> + int rc;
> +
> + if (dev->device_node) {
> + const struct of_device_id *match;
> + match = of_match_node(at91_pinctrl_dt_ids, dev->device_node);
> + if (!match)
> + ops_data = NULL;
> + else
> + ops_data = (struct at91_pinctrl_mux_ops *)match->data;
> + }
> + else {
> + rc = dev_get_drvdata(dev, (unsigned long *)&ops_data);
> + if (rc)
> + ops_data = NULL;
> + }
Indentation looks garbled in this function.
> +
> + ret = pinctrl_register(&info->pctl);
> + if (ret)
> + return ret;
> +
> + dev_info(dev, "AT91 pinctrl registred\n");
s/registred/registered/
> +
> + ret = gpiochip_add(&at91_gpio->chip);
> + if (ret) {
> + dev_err(dev, "couldn't add gpiochip, ret = %d\n", ret);
> + return ret;
> + }
> +
> + dev_info(dev, "AT91 gpio driver registred\n");
here aswell.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2014-08-04 18:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 13:24 [PATCH 0/2] Add atmel " Raphaël Poggi
2014-08-01 13:24 ` [PATCH 1/2] pinctrl: at91: add " Raphaël Poggi
2014-08-04 18:22 ` Sascha Hauer [this message]
2014-08-04 18:26 ` Jean-Christophe PLAGNIOL-VILLARD
2014-08-04 18:37 ` Raphaël Poggi
2014-08-04 18:45 ` Sascha Hauer
2014-08-05 10:26 ` Jean-Christophe PLAGNIOL-VILLARD
2014-08-05 11:38 ` Raphaël Poggi
[not found] ` <E10FE9F3-8D18-4EFC-8470-7C2D79E7E1B4@jcrosoft.com>
[not found] ` <CA5BE09F-18DF-49EE-83D8-65BB761BB903@jcrosoft.com>
2014-08-06 7:12 ` Raphaël Poggi
2014-08-01 13:24 ` [PATCH 2/2] at91sam9g45: add device tree gpio clocks Raphaël Poggi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140804182245.GE23235@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=poggi.raph@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox