* [PATCH] ubiformat: Include missing header
@ 2014-08-23 19:23 Ezequiel Garcia
2014-09-01 8:52 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Ezequiel Garcia @ 2014-08-23 19:23 UTC (permalink / raw)
To: barebox
Currently this warning is found when compiling ubiformat.c
CC commands/ubiformat.o
commands/ubiformat.c: In function 'flash_image':
commands/ubiformat.c:368:3: warning: implicit declaration of function 'read_full' [-Wimplicit-function-declaration]
err = read_full(fd, buf, mtd->eb_size);
^
because ubiformat.c needs libfile.h for the read_full() function.
This commit adds the missing header.
Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
---
commands/ubiformat.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/commands/ubiformat.c b/commands/ubiformat.c
index 443d645..df0b801 100644
--- a/commands/ubiformat.c
+++ b/commands/ubiformat.c
@@ -40,6 +40,7 @@
#include <malloc.h>
#include <ioctl.h>
#include <libbb.h>
+#include <libfile.h>
#include <linux/mtd/mtd.h>
#include <linux/kernel.h>
#include <linux/stat.h>
--
2.0.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ubiformat: Include missing header
2014-08-23 19:23 [PATCH] ubiformat: Include missing header Ezequiel Garcia
@ 2014-09-01 8:52 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2014-09-01 8:52 UTC (permalink / raw)
To: Ezequiel Garcia; +Cc: barebox
On Sat, Aug 23, 2014 at 04:23:48PM -0300, Ezequiel Garcia wrote:
> Currently this warning is found when compiling ubiformat.c
>
> CC commands/ubiformat.o
> commands/ubiformat.c: In function 'flash_image':
> commands/ubiformat.c:368:3: warning: implicit declaration of function 'read_full' [-Wimplicit-function-declaration]
> err = read_full(fd, buf, mtd->eb_size);
> ^
> because ubiformat.c needs libfile.h for the read_full() function.
> This commit adds the missing header.
>
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Should be fixed in master already.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-01 8:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-23 19:23 [PATCH] ubiformat: Include missing header Ezequiel Garcia
2014-09-01 8:52 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox