mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Raphaël Poggi" <poggi.raph@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 4/5] board: atmel: initialise ecc_mode
Date: Mon, 1 Sep 2014 11:54:25 +0200	[thread overview]
Message-ID: <20140901095425.GQ5352@pengutronix.de> (raw)
In-Reply-To: <1407230089-26948-5-git-send-email-poggi.raph@gmail.com>

On Tue, Aug 05, 2014 at 11:14:48AM +0200, Raphaël Poggi wrote:
> This commit initialise the ecc_mode (NAND_ECC_SOFT) on atmel board init which missing it.
> 
> Signed-off-by: Raphaël Poggi <poggi.raph@gmail.com>
> ---
>  arch/arm/boards/at91sam9260ek/init.c    |    1 +
>  arch/arm/boards/at91sam9261ek/init.c    |    1 +
>  arch/arm/boards/at91sam9263ek/init.c    |    1 +
>  arch/arm/boards/at91sam9m10g45ek/init.c |    1 +
>  arch/arm/boards/at91sam9m10ihd/init.c   |    1 +
>  5 files changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boards/at91sam9260ek/init.c b/arch/arm/boards/at91sam9260ek/init.c
> index 1298dde..76e0195 100644
> --- a/arch/arm/boards/at91sam9260ek/init.c
> +++ b/arch/arm/boards/at91sam9260ek/init.c
> @@ -51,6 +51,7 @@ static struct atmel_nand_data nand_pdata = {
>  	.det_pin	= -EINVAL,
>  	.rdy_pin	= AT91_PIN_PC13,
>  	.enable_pin	= AT91_PIN_PC14,
> +	.ecc_mode	= NAND_ECC_SOFT,

You have to combine 3/5 and 4/5 in a single patch. Otherwise the ecc
mode is not initialized correctly between both patches.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2014-09-01  9:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-05  9:14 [PATCH v2 0/5] Add device tree support of Atmel NAND driver Raphaël Poggi
2014-08-05  9:14 ` [PATCH 1/5] mtd: nand: remove NAND_ATMEL_PMECC Raphaël Poggi
2014-08-06  4:08   ` Jean-Christophe PLAGNIOL-VILLARD
2014-08-06  7:21     ` Raphaël Poggi
2014-09-01  9:49       ` Sascha Hauer
2014-08-05  9:14 ` [PATCH 2/5] board: atmel: initialise the has_pmecc member Raphaël Poggi
2014-08-05  9:14 ` [PATCH 3/5] mtd: atmel_nand: retrieve ecc_mode from pdata Raphaël Poggi
2014-08-05  9:14 ` [PATCH 4/5] board: atmel: initialise ecc_mode Raphaël Poggi
2014-09-01  9:54   ` Sascha Hauer [this message]
2014-08-05  9:14 ` [PATCH 5/5] mtd: atmel_nand: add support for device tree Raphaël Poggi
2014-08-05  9:40 ` [PATCH v2 0/5] Add device tree support of Atmel NAND driver Raphaël Poggi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140901095425.GQ5352@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=poggi.raph@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox