mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: barebox@lists.infradead.org
Subject: Re: [PATCH 2/2] EFI: handle more boot devices
Date: Mon, 1 Sep 2014 12:02:00 +0200	[thread overview]
Message-ID: <20140901100200.GA5271@pengutronix.de> (raw)
In-Reply-To: <20140901090619.GJ5352@pengutronix.de>

On Mon, Sep 01, 2014 at 11:06:19AM +0200, Sascha Hauer wrote:
> On Tue, Aug 12, 2014 at 11:37:21AM +0200, Michael Olbrich wrote:
> > efi_get_boot() fails for partitions that are not supported, so errors must
> > be ignored to find all supported devices.
> > 
> > Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> > ---
> > 
> > I'm not sure about this one. We're not doing anythings with the return
> > value of efi_get_boot(), so this is just some debug output + memory leak.
> 
> So maybe we should rather comment out the code until we do something
> meaningful with it?

I don't care either way. What's this stuff for anyways?

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2014-09-01 10:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-12  9:37 [PATCH 1/2] EFI: fix error handling in efi_get_boot() Michael Olbrich
2014-08-12  9:37 ` [PATCH 2/2] EFI: handle more boot devices Michael Olbrich
2014-09-01  9:06   ` Sascha Hauer
2014-09-01 10:02     ` Michael Olbrich [this message]
2014-09-01 10:12       ` Sascha Hauer
2014-09-01  9:03 ` [PATCH 1/2] EFI: fix error handling in efi_get_boot() Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140901100200.GA5271@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox