From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:6f8:1178:4:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XOPDC-0000ea-8v for barebox@lists.infradead.org; Mon, 01 Sep 2014 10:51:50 +0000 Date: Mon, 1 Sep 2014 12:51:21 +0200 From: Sascha Hauer Message-ID: <20140901105121.GW5352@pengutronix.de> References: <1406873830-17123-1-git-send-email-s.hauer@pengutronix.de> <20140801064502.GA27679@omega> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140801064502.GA27679@omega> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] commands: saveenv: Fix comment about directories in help text To: Alexander Aring Cc: barebox@lists.infradead.org On Fri, Aug 01, 2014 at 08:45:04AM +0200, Alexander Aring wrote: > Hi Sascha, > > On Fri, Aug 01, 2014 at 08:17:10AM +0200, Sascha Hauer wrote: > > envfs indeed handles directories, at least since 2007: > > > > | commit 913691eccd13c1509470eb8b059aa0beecc6d8d8 > > | Author: Sascha Hauer > > | Date: Tue Sep 25 12:58:52 2007 +0200 > > | > > | add directory handling for environment > > > > Signed-off-by: Sascha Hauer > > --- > > commands/saveenv.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/commands/saveenv.c b/commands/saveenv.c > > index 31d6951..9da733e 100644 > > --- a/commands/saveenv.c > > +++ b/commands/saveenv.c > > @@ -60,8 +60,7 @@ BAREBOX_CMD_HELP_TEXT("Save the files in DIRECTORY to the persistent storage dev > > BAREBOX_CMD_HELP_TEXT("") > > BAREBOX_CMD_HELP_TEXT("ENVFS is usually a block in flash but can be any other file. If") > > BAREBOX_CMD_HELP_TEXT("omitted, DIRECTORY defaults to /env and ENVFS defaults to") > > -BAREBOX_CMD_HELP_TEXT("/dev/env0. Note that envfs can only handle files, directories are being") > > -BAREBOX_CMD_HELP_TEXT("skipped silently.") > > +BAREBOX_CMD_HELP_TEXT("/dev/env0.") > > but envfs can't handle directories which are empty while saving? :-) > Maybe we should add this as note or support empty directories. I think we should add some more general docs how the environment works. That would be a more appropriate place to add this note. Otherwise we would have to add it to loadenv aswell. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox