mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] EFI: add missing include
@ 2014-09-03 13:18 Michael Olbrich
  2014-09-03 13:54 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Michael Olbrich @ 2014-09-03 13:18 UTC (permalink / raw)
  To: barebox; +Cc: Michael Olbrich

Otherwise building produces these warnings:
[...]
arch/efi/efi/efi-image.c:48:2: warning: implicit declaration of function 'read_file' [-Wimplicit-function-declaration]
arch/efi/efi/efi-image.c:48:6: warning: assignment makes pointer from integer without a cast [enabled by default]
[...]

And bootm fails for x86_64. The implicit declaration has an int as return
value, so half of the returned address is lost.

Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
---
 arch/efi/efi/efi-image.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/efi/efi/efi-image.c b/arch/efi/efi/efi-image.c
index 18757d2..d9edd91 100644
--- a/arch/efi/efi/efi-image.c
+++ b/arch/efi/efi/efi-image.c
@@ -31,6 +31,7 @@
 #include <linux/err.h>
 #include <boot.h>
 #include <fs.h>
+#include <libfile.h>
 #include <binfmt.h>
 #include <wchar.h>
 #include <mach/efi.h>
-- 
2.1.0


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] EFI: add missing include
  2014-09-03 13:18 [PATCH] EFI: add missing include Michael Olbrich
@ 2014-09-03 13:54 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2014-09-03 13:54 UTC (permalink / raw)
  To: Michael Olbrich; +Cc: barebox

On Wed, Sep 03, 2014 at 03:18:15PM +0200, Michael Olbrich wrote:
> Otherwise building produces these warnings:
> [...]
> arch/efi/efi/efi-image.c:48:2: warning: implicit declaration of function 'read_file' [-Wimplicit-function-declaration]
> arch/efi/efi/efi-image.c:48:6: warning: assignment makes pointer from integer without a cast [enabled by default]
> [...]
> 
> And bootm fails for x86_64. The implicit declaration has an int as return
> value, so half of the returned address is lost.
> 
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>

Applied, thanks

This is probably the last patch before the September Release.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-09-03 13:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-03 13:18 [PATCH] EFI: add missing include Michael Olbrich
2014-09-03 13:54 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox