From: Sascha Hauer <s.hauer@pengutronix.de>
To: Sebastian Block <basti@linux-source.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2] mtd: add mtdram device (which build mtd over ram area - useful for FRAM oder MRAM)
Date: Mon, 8 Sep 2014 08:23:17 +0200 [thread overview]
Message-ID: <20140908062317.GM5352@pengutronix.de> (raw)
In-Reply-To: <540AEE1F.5030504@linux-source.de>
On Sat, Sep 06, 2014 at 01:21:03PM +0200, Sebastian Block wrote:
> Change since v1 (Sascha, thanks for review):
> * use xzalloc instead of kzalloc and control check
> * correct help and names
> * fix coding style issue
> * remove verbose and unneeded messages
>
> This adds support for MTD in RAM devices (like FRAM or MRAM).
>
> Signed-off-by: Sebastian Block <basti@linux-source.de>
Your patch has several trailing whitespaces. Please remove them next
time.
> diff --git a/drivers/mtd/devices/mtdram.c b/drivers/mtd/devices/mtdram.c
> new file mode 100644
> index 0000000..47c5ad7
> --- /dev/null
> +++ b/drivers/mtd/devices/mtdram.c
> + *
Strange. the initial '/' introducing the comment is missing here. Also
git-am ended up creating an empty file. How did you generate/send this
patch?
> +static int mtdram_probe(struct device_d *dev)
> +{
> + void __iomem *base;
> + int device_id;
> + struct mtd_info *mtd;
> + struct resource *res;
> + loff_t size;
> + int ret = 0;
> +
> + mtd = xzalloc(sizeof(struct mtd_info), GFP_KERNEL);
xzalloc takes only one argument. Please compile test your patches before
sending them.
Anyway, fixed this up this time and applied.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-09-08 6:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-28 8:59 [PATCH] " basti
2014-08-28 11:51 ` Alexander Aring
2014-08-28 11:58 ` Alexander Aring
2014-09-01 8:06 ` Sascha Hauer
2014-09-06 11:21 ` [PATCH v2] " Sebastian Block
2014-09-08 6:23 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140908062317.GM5352@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=basti@linux-source.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox