From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Teresa Gámez" <t.gamez@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] commands: of_dump: Fix return value
Date: Fri, 12 Sep 2014 07:42:45 +0200 [thread overview]
Message-ID: <20140912054245.GR4992@pengutronix.de> (raw)
In-Reply-To: <1410447889-19648-1-git-send-email-t.gamez@phytec.de>
On Thu, Sep 11, 2014 at 05:04:49PM +0200, Teresa Gámez wrote:
> In an error case the return value is set nicely
> but 0 is always beeing returned.
>
> Signed-off-by: Teresa Gámez <t.gamez@phytec.de>
Applied, thanks
Sascha
> ---
> commands/of_dump.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/commands/of_dump.c b/commands/of_dump.c
> index 1222ebf..513a4b8 100644
> --- a/commands/of_dump.c
> +++ b/commands/of_dump.c
> @@ -34,7 +34,7 @@
> static int do_of_dump(int argc, char *argv[])
> {
> int opt;
> - int ret;
> + int ret = 0;
> int fix = 0;
> struct device_node *root = NULL, *node, *of_free = NULL;
> char *dtbfile = NULL;
> @@ -117,7 +117,7 @@ out:
> if (of_free)
> of_delete_node(of_free);
>
> - return 0;
> + return ret;
> }
>
> BAREBOX_CMD_HELP_START(of_dump)
> --
> 1.7.0.4
>
>
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-09-12 5:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 15:04 Teresa Gámez
2014-09-12 5:42 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140912054245.GR4992@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=t.gamez@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox