mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Franck Jullien <franck.jullien@gmail.com>
Cc: barebox <barebox@lists.infradead.org>
Subject: Re: Subject: [PATCH] cfi: print size in human readable format
Date: Wed, 24 Sep 2014 06:45:28 +0200	[thread overview]
Message-ID: <20140924044528.GY4992@pengutronix.de> (raw)
In-Reply-To: <CAJfOKBySWnQN+RNuZfET12sudUiWhTSV4bVL3xwYTkv-69YwXQ@mail.gmail.com>

Hi Franck,

On Tue, Sep 23, 2014 at 09:03:58AM +0200, Franck Jullien wrote:
> Not sure the patch format is ok. It sent it from my webmail (I'm not
> able to use git send-email here).

The patch has tabs converted to spaces. I applied it manually.

Thanks
 Sascha

> 
> Franck.
> 
> 2014-09-23 9:02 GMT+02:00 Franck Jullien <franck.jullien@gmail.com>:
> > From: Franck Jullien <franck.jullien@gmail.com>
> >
> > The CFI size is now printed in a human readable format.
> > It also adds "0x" prefix to the printed address.
> >
> > Signed-off-by: Franck Jullien <franck.jullien@gmail.com>
> > ---
> >  drivers/mtd/nor/cfi_flash.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mtd/nor/cfi_flash.c b/drivers/mtd/nor/cfi_flash.c
> > index a494063..0fa41bf 100644
> > --- a/drivers/mtd/nor/cfi_flash.c
> > +++ b/drivers/mtd/nor/cfi_flash.c
> > @@ -1000,8 +1000,8 @@ static int cfi_probe (struct device_d *dev)
> >                 return -ENODEV;
> >         }
> >
> > -       dev_info(dev, "found cfi flash at %p, size %ld\n",
> > -                       info->base, info->size);
> > +       dev_info(dev, "found cfi flash at 0x%p, size %s\n",
> > +                       info->base, size_human_readable(info->size));
> >
> >         dev->info = cfi_info;
> >
> > --
> > 2.1.0
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      reply	other threads:[~2014-09-24  4:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-23  7:02 Franck Jullien
2014-09-23  7:03 ` Franck Jullien
2014-09-24  4:45   ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140924044528.GY4992@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=franck.jullien@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox