From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 6/6] commands: implement 'diff' command
Date: Thu, 9 Oct 2014 08:50:35 +0200 [thread overview]
Message-ID: <20141009065035.GG4992@pengutronix.de> (raw)
In-Reply-To: <20141008193226.0863b6e28861fd5e0adf1dc0@gmail.com>
On Wed, Oct 08, 2014 at 07:32:26PM +0400, Antony Pavlov wrote:
> On Wed, 8 Oct 2014 16:24:15 +0200
> Sascha Hauer <s.hauer@pengutronix.de> wrote:
>
> > This command compares two files. It does not show the differences,
> > it only returns successfully if both files are identical and with
> > an error if they differ.
>
> Here are my two comments:
>
> 1. there is the 'cmp' command for simple comparing two files from Unix cmdline.
> Can we use 'cmp' name instead of 'diff'?
Yes, good idea. 'cmp' seems a better name. I changed it.
>
> 2. we already can use
> memcmp -s FILE1 -d FILE2 0 0
> for comparing files :)
I know. Admittedly I'm working on stuff where I need the diff_file (now
compare_file) C function. The cmp command is merely a vehicle to not
have the compare_file function unused in the tree until this work is
done ;)
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2014-10-09 6:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 14:24 [PATCH 1/6] fs: store pointer to fsdev instead of dev in struct filep Sascha Hauer
2014-10-08 14:24 ` [PATCH 2/6] fs: do not lookup global FILE * when the file is already available Sascha Hauer
2014-10-08 14:24 ` [PATCH 3/6] fs: Store the path in struct filep Sascha Hauer
2014-10-08 14:24 ` [PATCH 4/6] fs: implement fstat Sascha Hauer
2014-10-08 14:24 ` [PATCH 5/6] libfile: add diff_file function Sascha Hauer
2014-10-08 14:24 ` [PATCH 6/6] commands: implement 'diff' command Sascha Hauer
2014-10-08 15:32 ` Antony Pavlov
2014-10-09 6:50 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141009065035.GG4992@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=antonynpavlov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox