mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 0/3] fixes and sanity checks for mxs pinmuxing
Date: Mon, 27 Oct 2014 06:14:53 +0100	[thread overview]
Message-ID: <20141027051453.GV14443@pengutronix.de> (raw)
In-Reply-To: <1414104361-15956-1-git-send-email-u.kleine-koenig@pengutronix.de>

On Fri, Oct 24, 2014 at 12:45:58AM +0200, Uwe Kleine-König wrote:
> Hello,
> 
> this series helped me to find pinmuxing problems on an i.MX28 machine.
> 
> The pins either have a pull up, a bit keeper or neither. For example the pin
> ENET0_RXD2 has a bit keeper, and so doing
> 
> 	imx_gpio_mode(ENET0_RXD2 | VE_3_3V | STRENGTH(S8MA) | PULLUP(1))
> 
> obviously couldn't enable the pull up as requested. Instead it enabled the bit
> keeper. With this series the above call results in a message that the mode is
> invalid and the pullup and bitkeeper register settings are not touched.
> 
> Note that I didn't test on i.MX23 even though this SoC is affected, too. I
> currently don't have an i.MX23 handy, so I couldn't test this part.
> 
> Uwe Kleine-König (3):
>   mxs: iomux-imx28: Fix keeper/pullup/drive strength/voltage flags
>   mxs: iomux-imx23/imx28: unify mode definition
>   mxs: iomux-imx23/imx28: add additional checks on mode

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

      parent reply	other threads:[~2014-10-27  5:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-23 22:45 Uwe Kleine-König
2014-10-23 22:45 ` [PATCH 1/3] mxs: iomux-imx28: Fix keeper/pullup/drive strength/voltage flags Uwe Kleine-König
2014-10-23 22:46 ` [PATCH 2/3] mxs: iomux-imx23/imx28: unify mode definition Uwe Kleine-König
2014-10-24  7:50   ` Juergen Borleis
2014-10-24  8:19     ` Uwe Kleine-König
2014-10-24  8:47       ` Juergen Borleis
2014-11-03 12:18   ` Sascha Hauer
2014-10-23 22:46 ` [PATCH 3/3] mxs: iomux-imx23/imx28: add additional checks on mode Uwe Kleine-König
2014-10-24  7:52 ` [PATCH 0/3] fixes and sanity checks for mxs pinmuxing Juergen Borleis
2014-10-27  5:14 ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141027051453.GV14443@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox